Order of rate checks in InMemoryBucket seems odd.

[pafi-code]

Problem Description

In your InMemoryBucket you seem to sort the rates in the wrong order, no?

PyrateLimiter/pyrate_limiter/buckets/in_memory_bucket.py

Line 22 in 9cda625

self.rates = sorted(rates, key=lambda r: r.interval)

This means when I configure that I have a rates

[pyrate_limiter.Rate(3, pyrate_limiter.Duration.MINUTE), pyrate_limiter.Rate(1, pyrate_limiter.Duration.DAY)]

then always the minutes are checked first. So shouldn't the order when you sort the list of rates be reversed?

[vutran1710]

ah not quite. the intention here is, the more generous one should come before the tighter one. You can look at it as saying: we can allow 100 requests/sec but no more 200 requests/minute

[pafi-code]

Yea I get that this should be the way it's configured but still I could do what I did in my example 😆
So maybe the issue is not the order of the list, but the break in the for loop:

PyrateLimiter/pyrate_limiter/buckets/in_memory_bucket.py

Line 34 in 9cda625

break

[vutran1710]

I'll look at this soon.

[pafi-code]

In my opinion you have two options:

1. Do input validation on the rates and enforce the way you want it to be used as you suggested in your initial response
2. Remove the break and check all rates and only succeed of all of them succeed

I assume you would be in favor of the the 1. 😄