From c4d4a30eec600c13bb7fd2b15be1e7501573fc5b Mon Sep 17 00:00:00 2001
From: mason5052 <ehehwnwjs5052@gmail.com>
Date: Thu, 12 Mar 2026 14:05:16 -0400
Subject: [PATCH] test: add unit tests for pkg/providers/embeddings package

Add unit tests for the embedding provider factory function covering all
7 supported providers (OpenAI, Ollama, Mistral, Jina, Huggingface,
GoogleAI, VoyageAI), the none provider, unsupported provider error
handling, custom URL/key/model configuration, and IsAvailable behavior.
---
 .../pkg/providers/embeddings/embedder_test.go | 168 ++++++++++++++++++
 1 file changed, 168 insertions(+)
 create mode 100644 backend/pkg/providers/embeddings/embedder_test.go

diff --git a/backend/pkg/providers/embeddings/embedder_test.go b/backend/pkg/providers/embeddings/embedder_test.go
new file mode 100644
index 00000000..4b703665
--- /dev/null
+++ b/backend/pkg/providers/embeddings/embedder_test.go
@@ -0,0 +1,168 @@
+package embeddings
+
+import (
+	"testing"
+
+	"pentagi/pkg/config"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestNew_OpenAI(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "openai",
+		OpenAIKey:         "test-key",
+		OpenAIServerURL:   "https://api.openai.com/v1",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_OpenAI_WithCustomURL(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "openai",
+		EmbeddingURL:      "https://custom-openai.example.com",
+		EmbeddingKey:      "custom-key",
+		EmbeddingModel:    "text-embedding-3-small",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_Ollama(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "ollama",
+		EmbeddingURL:      "http://localhost:11434",
+		EmbeddingModel:    "nomic-embed-text",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_Mistral(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "mistral",
+		EmbeddingKey:      "test-key",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_Jina(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "jina",
+		EmbeddingKey:      "test-key",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_Huggingface(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "huggingface",
+		EmbeddingKey:      "test-key",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_GoogleAI(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "googleai",
+		EmbeddingKey:      "test-key",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_VoyageAI(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "voyageai",
+		EmbeddingKey:      "test-key",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.True(t, e.IsAvailable())
+}
+
+func TestNew_None(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "none",
+	}
+
+	e, err := New(cfg)
+	require.NoError(t, err)
+	assert.NotNil(t, e)
+	assert.False(t, e.IsAvailable())
+}
+
+func TestNew_UnsupportedProvider(t *testing.T) {
+	cfg := &config.Config{
+		EmbeddingProvider: "unknown-provider",
+	}
+
+	e, err := New(cfg)
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "unsupported embedding provider")
+	assert.NotNil(t, e)
+	assert.False(t, e.IsAvailable())
+}
+
+func TestNew_AllProviders_TableDriven(t *testing.T) {
+	providers := []struct {
+		name      string
+		provider  string
+		available bool
+	}{
+		{"openai", "openai", true},
+		{"ollama", "ollama", true},
+		{"mistral", "mistral", true},
+		{"jina", "jina", true},
+		{"huggingface", "huggingface", true},
+		{"googleai", "googleai", true},
+		{"voyageai", "voyageai", true},
+		{"none", "none", false},
+	}
+
+	for _, tt := range providers {
+		t.Run(tt.name, func(t *testing.T) {
+			cfg := &config.Config{
+				EmbeddingProvider: tt.provider,
+				EmbeddingKey:      "test-key",
+			}
+
+			e, err := New(cfg)
+			require.NoError(t, err)
+			assert.Equal(t, tt.available, e.IsAvailable())
+		})
+	}
+}
+
+func TestIsAvailable_NilEmbedder(t *testing.T) {
+	e := &embedder{nil}
+	assert.False(t, e.IsAvailable())
+}