how to view the Git Icon for toggleterm executable?

[PCesteban]

Hello! loving the new version! I was wondering how can I implement this feature that was removed in the new version.

Here is the exact issue for reference:
#57

I tried to look at the documentation but I'm not very good with Lua functions. I would appreciate any help.

[vyfor]

Hey, v2 should support terminal buffers and other terminal-related plugins out-of-the-box, including toggleterm. There hasn't been much testing in the terminal area, could it be not working as expected? Or is there something else you wish to achieve?

[vyfor]

Pushed a fix.
Thanks for reporting, and sorry for the inconvenience!

[vyfor]

As for the Git icon, it can be achieved by extracting the executable name from the filename in the pre_activity hook, and replacing filetype. If you'd like I can provide an example snippet of code.

[PCesteban]

yes please and thank you very much! Would be good to have such example in the docs (if it is then I missed it).

[vyfor]

This should do it:

{
  hooks = {
    pre_activity = function(opts)
      if opts.filetype == 'toggleterm' then
        local ft = opts.filename:match '%d+:([^.:&;]+)'
        if ft and ft ~= '' then opts.filetype = ft end
      end
    end,
  },
  assets = {
    lazygit = {
      name = 'Lazygit',
      tooltip = 'Terminal UI for Git commands',
      type = 'vcs',
    },
  }
}

You can add other executables to the assets list as well

[vyfor]

Would be good to have such example in the docs (if it is then I missed it).

It's not really mentioned anywhere in the docs, so the examples section might be a good place for it. I'm more inclined toward implementing this kind of pattern matching for all terminal buffer types. Could either be a built-in feature or a built-in plugin, not sure yet. Need to give it proper thought.