refactor(e2e): drop the dead test sharding from Initialize

Review feedback on kube-logging#2301. The sharding wrapped around t.Parallel was dead and
inverted.

sequence is a per-binary counter and ten of the thirteen suites hold exactly one
test, so localSeq is always 1 in those binaries. With SHARDS=2 that gives
1 % 2 != 0 for shard 0, which skips, against 1 % 2 == 1 for shard 1, which runs:
shard 0 would run nothing and shard 1 everything. Nothing exercised it either
way, because the matrix that would set SHARD and SHARDS is commented out in
e2e.yaml.

E2E_CLUSTERS bounds the concurrency the sharding was reaching for, so this drops
it rather than reworking it to shard on t.Name(), and leaves Initialize as the
bare t.Parallel the suites already expect.

Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>

Author: vyncint

e2e/common/helpers.go

@@ -17,13 +17,10 @@ package common
 import (
 	"context"
 	"fmt"
-	"os"
-	"sync/atomic"
 	"testing"
 	"time"
 
 	"emperror.dev/errors"
-	"github.com/spf13/cast"
 	"github.com/stretchr/testify/assert"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
@@ -48,8 +45,6 @@ const (
 	NodeExporterTag       = "local"
 )
 
-var sequence uint32
-
 func RequireNoError(t *testing.T, err error) {
 	if err != nil {
 		assert.Fail(t, fmt.Sprintf("Received unexpected error:\n%#v %+v", err, errors.GetDetails(err)))
@@ -58,14 +53,6 @@ func RequireNoError(t *testing.T, err error) {
 }
 
 func Initialize(t *testing.T) {
-	localSeq := atomic.AddUint32(&sequence, 1)
-	shards := cast.ToUint32(os.Getenv("SHARDS"))
-	shard := cast.ToUint32(os.Getenv("SHARD"))
-	if shards > 0 {
-		if localSeq%shards != shard {
-			t.Skipf("skipping %s as sequence %d not in shard %d", t.Name(), localSeq, shard)
-		}
-	}
 	t.Parallel()
 }