fix(e2e): carry the kubeconfig into the partial-cluster delete

Review feedback on kube-logging#2301. The delete that clears a half-built cluster after a
create times out did not name the kubeconfig the create used, so it fell back to
the shared default. That is the delete most likely to lose the lock, because it
runs exactly when several creates are timing out together.

The stalled-create case creates with a kubeconfig now, so the delete's arguments
are pinned rather than only its presence: without the fix it reports
`delete cluster --name stuck` against the expected
`delete cluster --kubeconfig /tmp/kind-stuck.kubeconfig --name stuck`.

Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>

Author: vyncint

e2e/internal/kind/commands.go

@@ -110,8 +110,13 @@ func (k *Kind) CreateCluster(options CreateClusterOptions) error {
 
 	case errors.Is(err, ErrTimeout):
 		// kind removes a half-built cluster when one of its own actions fails,
-		// but not when we kill it, so the leftovers have to go explicitly.
-		cleanupErr := k.deleteCluster(k.CleanupTimeout, DeleteClusterOptions{Name: options.Name})
+		// but not when we kill it, so the leftovers have to go explicitly. The
+		// kubeconfig has to come along: this delete runs when creates are timing
+		// out together, which is when a shared one loses the lock.
+		cleanupErr := k.deleteCluster(k.CleanupTimeout, DeleteClusterOptions{
+			Name:       options.Name,
+			Kubeconfig: options.Kubeconfig,
+		})
 		if cleanupErr != nil {
 			return fmt.Errorf("%w; deleting the partial cluster also failed: %w", err, cleanupErr)
 		}

e2e/internal/kind/commands_test.go

@@ -266,13 +266,20 @@ func TestInvocations(t *testing.T) {
 			want:    []string{"create cluster --name fine"},
 		},
 		// kind tears down a half-built cluster when one of its own actions
-		// fails, but not when we kill it, so the delete has to be ours.
+		// fails, but not when we kill it, so the delete has to be ours. It has
+		// to name the create's kubeconfig too: this is the delete that runs while
+		// several creates are timing out together.
 		"a stalled create deletes the partial cluster": {
 			sleepEnv: "FAKE_KIND_CREATE_SLEEP",
 			timeout:  shortTimeout,
-			invoke:   func(k *Kind) error { return k.CreateCluster(CreateClusterOptions{Name: "stuck"}) },
-			wantErr:  true,
-			want:     []string{"create cluster --name stuck", "delete cluster --name stuck"},
+			invoke: func(k *Kind) error {
+				return k.CreateCluster(CreateClusterOptions{Name: "stuck", Kubeconfig: "/tmp/kind-stuck.kubeconfig"})
+			},
+			wantErr: true,
+			want: []string{
+				"create cluster --kubeconfig /tmp/kind-stuck.kubeconfig --name stuck",
+				"delete cluster --kubeconfig /tmp/kind-stuck.kubeconfig --name stuck",
+			},
 		},
 		"an empty image list runs nothing": {
 			invoke:  func(k *Kind) error { return k.LoadDockerImage(nil, LoadDockerImageOptions{Name: "c"}) },