op-mode: T7527: move assorted embedded shel snippets to script files

Author: dmbaturin

op-mode-definitions/install-mok.xml.in

@@ -6,7 +6,7 @@
         <properties>
           <help>Install Secure Boot MOK (Machine Owner Key)</help>
         </properties>
-        <command>if test -f /var/lib/shim-signed/mok/vyos-dev-2025-shim.der; then mokutil --ignore-keyring --import /var/lib/shim-signed/mok/vyos-dev-2025-shim.der; else echo "Secure Boot Machine Owner Key not found"; fi</command>
+        <command>${vyos_op_scripts_dir}/install_mok.sh</command>
       </leafNode>
     </children>
   </node>

op-mode-definitions/show-interfaces-bonding.xml.in

@@ -23,7 +23,7 @@
                 <properties>
                   <help>Show detailed interface information</help>
                 </properties>
-                <command>if [ -f "/proc/net/bonding/$4" ]; then cat "/proc/net/bonding/$4"; else echo "Interface $4 does not exist!"; fi</command>
+                <command>${vyos_op_scripts_dir}/show_bonding_detail.sh "$4"</command>
               </leafNode>
               <node name="lacp">
                 <properties>

op-mode-definitions/show-interfaces-pppoe.xml.in

@@ -26,7 +26,7 @@
                     <path>interfaces pppoe</path>
                   </completionHelp>
                 </properties>
-                <command>if [ -d "/sys/class/net/$4" ]; then /usr/sbin/pppstats "$4"; fi</command>
+                <command>${vyos_op_scripts_dir}/show_ppp_stats.sh "$4"</command>
               </leafNode>
               #include <include/show-interface-type-event-log.xml.i>
             </children>

op-mode-definitions/show-interfaces-sstpc.xml.in

@@ -26,7 +26,7 @@
                     <path>interfaces sstpc</path>
                   </completionHelp>
                 </properties>
-                <command>if [ -d "/sys/class/net/$4" ]; then /usr/sbin/pppstats "$4"; fi</command>
+                <command>${vyos_op_scripts_dir}/show_ppp_stats.sh "$4"</command>
               </leafNode>
               #include <include/show-interface-type-event-log.xml.i>
             </children>

op-mode-definitions/suricata.xml.in

@@ -6,7 +6,7 @@
         <properties>
           <help>Update Suricata</help>
         </properties>
-        <command>if test -f /run/suricata/suricata.yaml; then suricata-update --suricata-conf /run/suricata/suricata.yaml; systemctl restart suricata; else echo "Service Suricata not configured"; fi </command>
+        <command>${vyos_op_scripts_dir}/update_suricata.sh</command>
       </node>
     </children>
   </node>

src/op_mode/install_mok.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+if test -f /var/lib/shim-signed/mok/vyos-dev-2025-shim.der; then
+    mokutil --ignore-keyring --import /var/lib/shim-signed/mok/vyos-dev-2025-shim.der;
+else
+    echo "Secure Boot Machine Owner Key not found";
+fi

src/op_mode/show_bonding_detail.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+
+if [ -f "/proc/net/bonding/$1" ]; then
+  cat "/proc/net/bonding/$1";
+else
+  echo "Interface $1 does not exist!";
+fi

src/op_mode/show_ppp_stats.sh

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+if [ -d "/sys/class/net/$1" ]; then
+  /usr/sbin/pppstats "$1";
+fi

src/op_mode/update_suricata.sh

@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if test -f /run/suricata/suricata.yaml; then
+  suricata-update --suricata-conf /run/suricata/suricata.yaml;
+  systemctl restart suricata;
+else
+  echo "Service Suricata not configured";
+fi