Commit 7a0ba32
committed
Makefile: T9099: stop catch-all rule from eating forwarded test arguments
Test targets forward extra CLI arguments to their scripts via
$(filter-out $@,$(MAKECMDGOALS)) (e.g. make test -- --match interfaces_bond)
Those extra words are also goals as far as make is concerned, so after the test
recipe succeeded, make went on to "build" --match and interfaces_bond too,
falling through to the generic `%:` flavor rule and running
build-vyos-image --match
which errored and masked the fact that the smoketest itself had already passed.
Declare the trailing goals as phony no-ops when the primary target is one of
the test targets, so they no longer reach the `%:` rule.
The existing MATCH=<value> form is unaffected.1 parent 802f45d commit 7a0ba32
1 file changed
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
7 | 16 | | |
8 | 17 | | |
9 | 18 | | |
| |||
0 commit comments