T6516: frr: fix isisd advertise-passive-only - #1040
Merged
Merged
Conversation
The patch 0008-isis-fix-advertise-passive-only-routes-install.patch fixes installing routes even when advertise-passive-only is enabled. Previously active circuits were ignored completely, patch makes isisd just not to advertise prefixes from active circuits, but install routes from them and do all other processing. FRR PR: FRRouting/frr#19593
|
👍 |
sever-sever
approved these changes
Sep 25, 2025
sever-sever
left a comment
sever-sever
left a comment
Member
There was a problem hiding this comment.
Checked by @aapostoliuk
Approved
dmbaturin
approved these changes
Sep 25, 2025
dmbaturin
left a comment
dmbaturin
left a comment
Member
There was a problem hiding this comment.
I cannot see any logic issues so far, and I trust your testing.
vyosbot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FRR: fix isisd advertise-passive-only routes installation
The patch 0008-isis-fix-advertise-passive-only-routes-install.patch fixes installing routes even when advertise-passive-only is enabled.
Previously active circuits were ignored completely, patch makes isisd just not to advertise prefixes from active circuits, but install routes from them and do all other processing.
FRR PR: FRRouting/frr#19593
Types of changes
Related Task(s)
Related PR(s)
Checklist: