T9164: accept NOS-/VD- Jira keys in task-id check; pin NOS in coderabbit - #1260
Merged
Conversation
VD tracker project renamed to NOS (2026-07) - PR titles and commit headlines using the new NOS- key must stop being flagged invalid-task-id; legacy VD- keys stay accepted, and CodeRabbit now resolves NOS alongside VD. Fleet replication of canary vyos/vyos-1x#5379, whose adversarial review tightened the regexes to ASCII [0-9] + literal-space separators. 🤖 Generated by [robots](https://vyos.io)
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 📃 Configuration Change RequirementsMergify configuration change
|
|
CI integration 👍 passed! Details
|
andamasov
marked this pull request as ready for review
August 5, 2026 09:29
![vyos-bot[bot]](https://avatars.githubusercontent.com/in/3860201?s=60&v=4){kind=small}
vyos-bot
Bot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet replication of the adversarially-reviewed canary vyos/vyos-1x#5379 for the VD→NOS Jira project rename (T9164).
.github/mergify.yml— theinvalid-task-idrule's two regexes and itsdescriptionnow acceptT<digits>:,NOS-<digits>:and legacyVD-<digits>:keys; the rule name is byte-identical, so this stays additive rather than anextends:override..coderabbit.yaml—knowledge_base.jira.project_keyspinsNOSahead of the retained legacyVD. Byte-identical template application —skip-adversarialper the documented escape hatch (2 findings were found and fixed on the canary; regexes ship tightened: ASCII digits + literal-space separators).Phase 0 (local CodeRabbit CLI,
--base origin/rolling): clean — 0 findings.Advances: IS-640
🤖 Generated by robots