InvalidLiteral when array literal contains elements of different lengths

[cyberthirst]

Version Information

• vyper Version (output of vyper --version): 17322bb

What's your issue about?

Mixing a concat() call with a string literal in a DynArray initializer fails to compile, even though both values are valid String[32] elements.

@external
def foo():
    x: DynArray[String[32], 10] = [concat("a", "a"), "bar"]

vyper.exceptions.InvalidLiteral: Array contains multiple, incompatible types

  contract "test.vy:2", function "foo", line 2:32
       1 def foo():
  ---> 2   x: DynArray[String[32], 10] = [concat("a", "a"), "bar"]
  ---------------------------------------^
       3

Using two plain literals works fine:

x: DynArray[String[32], 10] = ["aa", "bar"]  # compiles

[cyberthirst]

The issue will probably stem from calling compare_type on bytestrings with different lengths. This also doesn't compile (neither does it compile when using Bytes[x] type:

@external
def foo():
    x: String[2] = "aa"
    y: DynArray[String[32], 10] = [x, "bar"]  # same error

[cyberthirst]

This also affects integer types — mixing uint8 and uint256 variables in a DynArray[uint256, 10] fails the same way:

@external
def foo():
    x: uint256 = 1
    z: uint8 = 2
    y: DynArray[uint256, 10] = [x, z]  # same error

we try to unify the types inside the list between themself without considering the target type..

i guess the cleanest fix would be to implement #4267

[cyberthirst]

Nested DynArray literals with different shapes in a ternary also trigger the same error:

@external
def f() -> DynArray[DynArray[bool, 5], 3]:
    return [[True, False]] if True else [[True], [False]]

vyper.exceptions.TypeMismatch: Dislike types: bool[2][1] and bool[1][2]

  contract "test.vy:3", function "f", line 3:11
       2 def f() -> DynArray[DynArray[bool, 5], 3]:
  ---> 3     return [[True, False]] if True else [[True], [False]]
  ------------------^
       4