What if your component already extends a class?

[jsdevtom]

Thank you for this library.

I would like to ask how to handle the scenario where a component already extends another class and where that parent class cannot extend OnDestroyMixin? E.g.:

@Component({/*...*/})
class ExampleFormComponent extends TypedForm<Example> {
    // ...
}

Obviously, this just worked in previous versions of this library because there was no inheritance required.

If this is/should not be possible with this library, please say.

[romanroe]

Hi @jsdevtom !

The next version could support the mixin pattern (https://www.typescriptlang.org/docs/handbook/mixins.html). However, this would require ES6 output hence this library wouldn't work in IE11 anymore. Personally, I am OK with this, but I would like to get some feedback before.

In the meantime, you could try a generic TypeScript mixin library. However, I haven't tested any with ngx-componentdestroyed.

@sengmann @kaihenzler What do you think?

[iamtheddrman]

I'll throw a vote in for dropping IE11 support if it means use of the mixin pattern. This tool has been invaluable as we upgrade our ancient AngularJS 1.5 project to Angular 14, but I just bumped into an issue with a component that needs to extend an abstract base class AND OnDestroyMixin to get the tool to work. I'm having to drop back to the old way of doing things and it's a lot less pretty/convenient.

Any insight on how a generic mixin library would work with ngx-componentdestroyed would also be much appreciated. We're a bit in over our heads over here right now.

[kaihenzler]

I'll throw a vote in for dropping IE11 support if it means use of the mixin pattern. This tool has been invaluable as we upgrade our ancient AngularJS 1.5 project to Angular 14, but I just bumped into an issue with a component that needs to extend an abstract base class AND OnDestroyMixin to get the tool to work. I'm having to drop back to the old way of doing things and it's a lot less pretty/convenient.

Any insight on how a generic mixin library would work with ngx-componentdestroyed would also be much appreciated. We're a bit in over our heads over here right now.

Maybe you could have a look at this library: https://github.com/tannerntannern/ts-mixer#basic-example
We currently don't know if it works for this usecase. It might be that its incompatible with the angular compiler.

[sengmann]

I am in favor of dropping the IE11 support.