Skip to content

Commit b833db1

Browse files
committed
Accessibility optimizations flowfield fragment layout
1 parent c3e5b47 commit b833db1

File tree

3 files changed

+19
-49
lines changed

3 files changed

+19
-49
lines changed

.idea/workspace.xml

Lines changed: 4 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/src/main/res/layout/main_fragment_flowfield.xml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,37 +30,39 @@
3030

3131
<androidx.appcompat.widget.AppCompatImageButton
3232
android:id="@+id/navigation_drawer_button_burger"
33-
android:layout_height="27dp"
34-
android:layout_width="27dp"
33+
android:layout_height="48dp"
34+
android:layout_width="48dp"
3535
android:layout_marginStart="30dp"
3636
android:layout_marginTop="30dp"
37+
android:contentDescription="@string/main_menu_toggle"
3738

3839
android:background="@android:color/transparent"
3940
android:src="@drawable/baseline_menu_24"/>
4041

4142
<androidx.appcompat.widget.AppCompatImageButton
4243
android:id="@+id/navigation_drawer_button_arrow"
43-
android:layout_height="27dp"
44-
android:layout_width="27dp"
44+
android:layout_height="48dp"
45+
android:layout_width="48dp"
4546
android:layout_marginStart="30dp"
4647
android:layout_marginTop="30dp"
47-
48-
android:alpha="0"
48+
android:contentDescription="@string/main_menu_toggle"
4949

5050
android:background="@android:color/transparent"
51-
android:src="@drawable/baseline_arrow_back_24"/>
51+
android:src="@drawable/baseline_arrow_back_24"
52+
53+
android:alpha="0"/>
5254

5355
<!-- Image Selection -->
5456

5557
<com.autocrop.activities.main.fragments.flowfield.views.ImageSelectionButton
5658
android:id="@+id/image_selection_button"
57-
style="@style/Base.Widget.AppCompat.Button.Colored"
58-
android:background="@drawable/button_image_selection"
59-
60-
android:layout_width="136dp"
59+
android:layout_width="143dp"
6160
android:layout_height="143dp"
6261
android:layout_centerInParent="true"
6362

63+
style="@style/Base.Widget.AppCompat.Button.Colored"
64+
android:background="@drawable/button_image_selection"
65+
6466
android:fontFamily="sans-serif"
6567
android:text="@string/image_selection_button"
6668
android:textAppearance="@style/TextAppearance.AppCompat.Body1"

app/src/main/res/values/strings.xml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,21 @@
11
<resources>
22
<string name="app_title">AutoCrop</string>
33

4-
<!-- Views -->
54
<string name="cropping_in_progress">Cropping…</string>
65
<string name="fracture">%1$d/%2$d</string>
76
<string name="crops_processing_in_progress">Processing crops…</string>
87
<string name="cropping_failure">No cropping borders found</string>
98
<string name="cancel_autoscroll">Cancel Scroll</string>
109
<string name="remove">Removed</string>
1110
<string name="cropping_failure_instruction_text_view">Make sure the selected screenshots comprise a continuous monochromatic border both above and below the core image area</string>
12-
1311
<string name="version">Version: %1$s</string>
1412
<string name="copyright">© 2021-%1$d | Janek Zangenberg</string>
1513

16-
<!-- Button -->
17-
18-
<!-- Text -->
1914
<string name="image_selection_button">SELECT IMAGES</string>
20-
21-
<!-- Description -->
2215
<string name="menu_inflation_button_description">Inflate settings menu</string>
2316
<string name="screenshot_button_description">Capture Flow Field image</string>
2417
<string name="crop_sharing_button_description">Share saved crops</string>
2518

26-
<!-- Menu Item Text -->
2719
<string name="menu_item_divider_examination">Examination</string>
2820
<string name="menu_item_divider_crop_saving">Crop Saving</string>
2921
<string name="menu_item_divider_other">Other</string>
@@ -32,6 +24,7 @@
3224
<string name="menu_item_rate_the_app">Rate the app</string>
3325
<string name="menu_item_about">About</string>
3426
<string name="menu_item_change_directory">Change Directory</string>
27+
3528
<string name="got_it">Got it</string>
3629
<string name="by">By:</string>
3730
<string name="w2sv">W2SV</string>
@@ -48,5 +41,6 @@
4841
<string name="discard">Discard</string>
4942
<string name="code">Code</string>
5043
<string name="share_crops">Share Crops</string>
44+
<string name="main_menu_toggle">Main menu toggle</string>
5145

5246
</resources>

0 commit comments

Comments
 (0)