Skip to content

Commit 5445a55

Browse files
committed
Polish workflow
1 parent ba5d25c commit 5445a55

File tree

3 files changed

+13
-16
lines changed

3 files changed

+13
-16
lines changed

.github/signing_setup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ decode_env_to_file() {
1616
fi
1717
}
1818

19-
decode_env_to_file "SIGNING_KEYSTORE" "../keys.jks"
20-
decode_env_to_file "SIGNING_PROPERTIES" "../keys.properties"
19+
decode_env_to_file "SIGNING_KEYSTORE" "keys.jks"
20+
decode_env_to_file "SIGNING_PROPERTIES" "keys.properties"

.github/workflows/gh_apk_release.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1+
name: Create GitHub APK Release
12
on: workflow_dispatch
23

34
env:
45
GRADLE_OPTS: -Dorg.gradle.jvmargs="-Xmx3072m -XX:MaxMetaspaceSize=1g -Xms512m -XX:+HeapDumpOnOutOfMemoryError"
5-
SIGNING_KEYSTORE_PLAY: ${{ secrets.SIGNING_KEYSTORE }}
6-
SIGNING_PROPERTIES_PLAY: ${{ secrets.SIGNING_PROPERTIES }}
6+
SIGNING_KEYSTORE: ${{ secrets.SIGNING_KEYSTORE }}
7+
SIGNING_PROPERTIES: ${{ secrets.SIGNING_PROPERTIES }}
78

89
jobs:
910
build:
@@ -18,7 +19,7 @@ jobs:
1819
distribution: temurin
1920

2021
- name: Setup Signing
21-
run: .github/signing_setup.sh
22+
run: chmod +x .github/signing_setup.sh && .github/signing_setup.sh
2223

2324
- name: Build release APK
2425
run: ./gradlew assembleRelease
@@ -28,7 +29,7 @@ jobs:
2829
run: echo "VERSION=$(grep -Po '^version=\K.*' gradle.properties)" >> $GITHUB_OUTPUT
2930

3031
- name: Create Github Release
31-
uses: softprops/action-gh-release@v1
32+
uses: softprops/action-gh-release@v2
3233
with:
3334
tag_name: ${{ steps.version.outputs.VERSION }}
3435
files: app/build/outputs/apk/release/${{ steps.version.outputs.VERSION }}.apk

app/build.gradle.kts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,12 @@ android {
2323
}
2424
signingConfigs {
2525
create("release") {
26-
val keystorePropertiesFile = rootProject.file("keystore.properties")
27-
if (keystorePropertiesFile.exists()) {
28-
val keystoreProperties = Properties().apply { load(FileInputStream(keystorePropertiesFile)) }
29-
30-
storeFile = rootProject.file("keys.jks")
31-
storePassword = keystoreProperties["storePassword"] as String
32-
keyAlias = keystoreProperties["keyAlias"] as String
33-
keyPassword = keystoreProperties["keyPassword"] as String
34-
}
26+
val keystoreProperties = Properties()
27+
.apply { load(FileInputStream(rootProject.file("keystore.properties"))) }
28+
storeFile = rootProject.file("keys.jks")
29+
storePassword = keystoreProperties["storePassword"] as String
30+
keyAlias = keystoreProperties["keyAlias"] as String
31+
keyPassword = keystoreProperties["keyPassword"] as String
3532
}
3633
}
3734
buildTypes {
@@ -46,7 +43,6 @@ android {
4643
"proguard-rules.pro"
4744
)
4845
// isDebuggable = true
49-
signingConfig = signingConfigs.getByName("release")
5046
}
5147
}
5248
buildFeatures {

0 commit comments

Comments
 (0)