Skip to content

Commit 6a5afc5

Browse files
committed
1.4.06
1 parent f080728 commit 6a5afc5

File tree

5 files changed

+836
-884
lines changed

5 files changed

+836
-884
lines changed

app/src/main/kotlin/com/w2sv/wifiwidget/ui/screens/home/components/widget/configurationdialog/WidgetConfigurationDialogContent.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import androidx.compose.ui.unit.dp
1717
import androidx.lifecycle.compose.collectAsStateWithLifecycle
1818
import com.w2sv.domain.model.WidgetBottomRowElement
1919
import com.w2sv.domain.model.WidgetRefreshingParameter
20+
import com.w2sv.domain.model.WidgetWifiProperty
2021
import com.w2sv.wifiwidget.R
2122
import com.w2sv.wifiwidget.ui.components.IconHeader
2223
import com.w2sv.wifiwidget.ui.screens.home.components.locationaccesspermission.states.LocationAccessState
@@ -27,6 +28,7 @@ import com.w2sv.wifiwidget.ui.screens.home.components.widget.configurationdialog
2728
import com.w2sv.wifiwidget.ui.screens.home.components.widget.configurationdialog.model.UnconfirmedWidgetConfiguration
2829
import com.w2sv.wifiwidget.ui.utils.toColor
2930
import kotlinx.collections.immutable.persistentListOf
31+
import kotlinx.collections.immutable.persistentMapOf
3032
import kotlinx.collections.immutable.toPersistentList
3133

3234
private val verticalSectionHeaderPadding = 22.dp
@@ -78,6 +80,7 @@ fun WidgetConfigurationDialogContent(
7880
locationAccessState = locationAccessState
7981
),
8082
showInfoDialog = showPropertyInfoDialog,
83+
propertyToSubTitleResId = widgetWifiPropertyToSubTitleResId
8184
)
8285

8386
SectionHeader(
@@ -127,6 +130,12 @@ fun WidgetConfigurationDialogContent(
127130
}
128131
}
129132

133+
private val widgetWifiPropertyToSubTitleResId = persistentMapOf(
134+
WidgetWifiProperty.NonIP.LocationAccessRequiring.entries.first() to R.string.location_access_requiring,
135+
WidgetWifiProperty.IP.entries.first() to R.string.ip_addresses,
136+
WidgetWifiProperty.NonIP.Other.entries.first() to R.string.other
137+
)
138+
130139
@Composable
131140
private fun SectionHeader(
132141
@DrawableRes iconRes: Int,

app/src/main/kotlin/com/w2sv/wifiwidget/ui/screens/home/components/widget/configurationdialog/components/PropertyCheckRow.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,20 @@ import com.w2sv.wifiwidget.ui.screens.home.components.widget.configurationdialog
3434
import com.w2sv.wifiwidget.ui.screens.home.components.widget.configurationdialog.model.PropertyCheckRowData
3535
import com.w2sv.wifiwidget.ui.utils.thenIf
3636
import kotlinx.collections.immutable.ImmutableList
37+
import kotlinx.collections.immutable.ImmutableMap
3738

3839
@Composable
3940
fun PropertyCheckRows(
4041
dataList: ImmutableList<PropertyCheckRowData<*>>,
4142
modifier: Modifier = Modifier,
43+
propertyToSubTitleResId: ImmutableMap<*, Int>? = null,
4244
showInfoDialog: ((InfoDialogData) -> Unit)? = null
4345
) {
4446
Column(modifier = modifier) {
4547
dataList
4648
.forEach { data ->
4749
// Display PropertySubTypeHeader if applicable
48-
propertyToSubTitleResId[data.property as? WidgetWifiProperty]?.let { resId ->
50+
propertyToSubTitleResId?.get(data.property)?.let { resId ->
4951
Text(
5052
text = stringResource(id = resId),
5153
color = MaterialTheme.colorScheme.secondary,
@@ -81,12 +83,6 @@ fun PropertyCheckRows(
8183
}
8284
}
8385

84-
private val propertyToSubTitleResId = mapOf(
85-
WidgetWifiProperty.NonIP.LocationAccessRequiring.entries.first() to R.string.location_access_requiring,
86-
WidgetWifiProperty.IP.entries.first() to R.string.ip_addresses,
87-
WidgetWifiProperty.NonIP.Other.entries.first() to R.string.other
88-
)
89-
9086
@Composable
9187
private fun SubPropertyCheckRowColumn(
9288
dataList: ImmutableList<PropertyCheckRowData<*>>,
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
- Performance improvements
2-
- Fixed a bug that would lead to all IP address versions of an address kind being displayed, regardless of the respectively selected ones
2+
- Hide bottom bar upon deselection of all comprised elements
3+
- Remove 'Buttons' category and display all buttons alongside with 'Last refresh time display' under the category 'Bottom Row' in the widget configuration dialog

0 commit comments

Comments
 (0)