Skip to content

Commit 7f0e3a7

Browse files
committed
Improve linting
1 parent 081edfc commit 7f0e3a7

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ lint:
1313
@./gradlew lint
1414

1515
check:
16-
@./gradlew ktlintCheck
1716
@./gradlew check
1817

1918
ktlint-format:

app/build.gradle.kts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ android {
7171
excludes.add("/META-INF/*")
7272
}
7373
}
74+
lint {
75+
checkDependencies = true
76+
xmlReport = false
77+
htmlReport = true
78+
textReport = false
79+
htmlOutput = project.layout.buildDirectory.file("reports/lint-results-debug.html").get().asFile
80+
}
7481
hilt {
7582
enableAggregatingTask = true // Fixes warning
7683
}

app/lint.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
<lint>
33
<!--Allow CompositionLocal's-->
44
<issue id="ComposeCompositionLocalUsage" severity="ignore" />
5-
<issue id="SlotReused" severity="warning" />
65
<issue id="NotificationPermission" severity="warning" />
76
<issue id="LintError" severity="warning" />
87
<issue id="MonochromeLauncherIcon" severity="ignore" />
98
<issue id="ComposeModifierMissing" severity="ignore" />
10-
</lint>
9+
</lint>

app/src/main/kotlin/com/w2sv/wifiwidget/ui/utils/OptionalAnimatedVisibility.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import androidx.compose.foundation.layout.ColumnScope
1111
import androidx.compose.runtime.Composable
1212
import androidx.compose.ui.Modifier
1313

14+
@Suppress("SlotReused")
1415
@Composable
1516
fun ColumnScope.OptionalAnimatedVisibility(
1617
visible: (() -> Boolean)?,

core/widget/src/main/res/values/strings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
<string name="refresh_data">Refresh data</string>
55
<string name="no_wifi_connection">No WiFi Connection</string>
66
<string name="wifi_disabled">WiFi Disabled</string>
7-
<string name="loading">Loading...</string>
7+
<string name="loading">Loading</string>
88
<string name="copied_to_clipboard">Copied %1$s to clipboard.</string>
9-
</resources>
9+
</resources>

0 commit comments

Comments
 (0)