Merge pull request #1344 from w3c/development

Create March 17, 2025 Release [2]

Includes the following changes:

* #1336, which addresses #1334
* #1340 
* #1339

Author: howard-e

client/components/CandidateReview/CandidateModals/NotApprovedModal/index.jsx

@@ -15,7 +15,7 @@ const NotApprovedModal = ({ handleAction = () => {}, githubUrl = '#' }) => {
         <>
           <p className="review-confirmation-content">Thank you for reviewing</p>
           <p className="review-confirmation-share">
-            if you haven’t opened any issues yet, please{' '}
+            If you haven’t opened any issues yet, please{' '}
             <a href={githubUrl} target="_blank" rel="noreferrer">
               open an issue describing why this is not approved.
             </a>

client/components/CandidateReview/CandidateTestPlanRun/index.jsx

@@ -360,6 +360,7 @@ const CandidateTestPlanRun = () => {
     isCandidateReviewChangesRequested: false,
     testTitle: undefined,
     testRowNumber: undefined,
+    testSequenceNumber: undefined,
     testRenderedUrl: undefined
   });
 

client/tests/e2e/snapshots/saved/_account_settings.html

@@ -99,7 +99,7 @@ <h2>Admin Actions</h2>
               <button type="button" class="btn btn-primary">
                 Import Latest Test Plan Versions
               </button>
-              <p>Date of latest test plan version: March 6, 2025 19:25 UTC</p>
+              <p>Date of latest test plan version: March 14, 2025 18:33 UTC</p>
             </section>
           </div>
         </main>

client/tests/e2e/snapshots/saved/_data-management.html

@@ -2210,7 +2210,7 @@ <h2>Test Plans Status Summary</h2>
                 <td>
                   <div class="css-bpz90">
                     <span class="rd full-width css-be9e2a">R&amp;D</span>
-                    <p class="review-text">Complete <b>Mar 6, 2025</b></p>
+                    <p class="review-text">Complete <b>Mar 14, 2025</b></p>
                   </div>
                 </td>
                 <td>
@@ -2233,7 +2233,7 @@ <h2>Test Plans Status Summary</h2>
                             <path
                               fill="currentColor"
                               d="M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209L241 337c-9.4 9.4-24.6 9.4-33.9 0l-64-64c-9.4-9.4-9.4-24.6 0-33.9s24.6-9.4 33.9 0l47 47L335 175c9.4-9.4 24.6-9.4 33.9 0s9.4 24.6 0 33.9z"></path></svg
-                          ><b>V25.03.06</b></span
+                          ><b>V25.03.14</b></span
                         ></a
                       ></span
                     ><button

client/utils/createIssueLink.js

@@ -3,13 +3,51 @@ const GITHUB_ISSUES_URL =
     ? 'https://github.com/w3c/aria-at'
     : 'https://github.com/bocoup/aria-at';
 
+// Maximum URL length for GitHub issues
+// Tested on multiple browsers and devices
+const MAX_GITHUB_URL_LENGTH = 8000;
+
 // TODO: Use At.key
 const atLabelMap = {
   'VoiceOver for macOS': 'vo',
   JAWS: 'jaws',
   NVDA: 'nvda'
 };
 
+/**
+ * Returns a truncation message for URLs that are too long.
+ *
+ * @param {number|null} testSequenceNumber - Optional test sequence number to include in truncation message
+ * @returns {string} The truncation message
+ */
+const getTruncationMessage = (testSequenceNumber = null) => {
+  return `...\n\n[**Content truncated due to URL length limits.** Please visit [${
+    window.location
+  }](${window.location}) to review ${
+    !testSequenceNumber ? 'further' : `Test ${testSequenceNumber}`
+  }.]`;
+};
+
+/**
+ * Truncates a body string to ensure the resulting URL stays under the maximum length.
+ *
+ * @param {string} body - The original body content
+ * @param {string} baseUrl - The URL without the body (including title and labels)
+ * @param {number|null} testSequenceNumber - Optional test sequence number to include in truncation message
+ * @returns {string} The truncated body that will keep the URL under the maximum length
+ */
+const truncateUrlBody = (body, baseUrl, testSequenceNumber = null) => {
+  const maxUrlLength = MAX_GITHUB_URL_LENGTH;
+  const truncationMessage = getTruncationMessage(testSequenceNumber);
+
+  // Multiply by 0.65 to account for encoding
+  const maxBodyLength = Math.floor(
+    (maxUrlLength - baseUrl.length - truncationMessage.length) * 0.65
+  );
+
+  return body.substring(0, maxBodyLength) + truncationMessage;
+};
+
 /**
  * Creates a link to open a new issue on the GitHub repository.
  *
@@ -183,10 +221,19 @@ const createIssueLink = ({
     body += `\n${conflictMarkdown}`;
   }
 
-  return (
-    `${GITHUB_ISSUES_URL}/issues/new?title=${encodeURI(title)}&` +
-    `labels=${labels}&body=${encodeURIComponent(body)}`
-  );
+  // Create the base URL without the body
+  const baseUrl = `${GITHUB_ISSUES_URL}/issues/new?title=${encodeURI(
+    title
+  )}&labels=${labels}&body=`;
+
+  let url = baseUrl + encodeURIComponent(body);
+
+  if (url.length > MAX_GITHUB_URL_LENGTH) {
+    body = truncateUrlBody(body, baseUrl, testSequenceNumber);
+    url = baseUrl + encodeURIComponent(body);
+  }
+
+  return url;
 };
 
 /**

server/resolvers/helpers/processCopiedReports.js

@@ -329,6 +329,11 @@ const processCopiedReports = async ({
     );
 
     for (const oldTestPlanRun of oldTestPlanReport.testPlanRuns) {
+      // Don't create a new test plan run if previous run was for a bot to avoid unexpected assignment results
+      // Bot assignments orchestrated and controlled by separate system
+      const isBotIdRegex = /^9\d{3}$/; // Currently, user ids for bots are in the format '9XXX'
+      if (isBotIdRegex.test(oldTestPlanRun.testerUserId)) continue;
+
       const oldTestPlanRunVendorReviewStatus =
         oldTestPlanReport.vendorReviewStatus;
 

server/services/GithubService.js

@@ -49,7 +49,7 @@ const getAllIssues = async () => {
       // Our issue API should only return issues that were originally
       // created by the app, indicated by the presence of metadata
       // hidden in a comment
-      .filter(data => data.body.includes('ARIA_AT_APP_ISSUE_DATA'));
+      .filter(data => data.body?.includes('ARIA_AT_APP_ISSUE_DATA'));
 
     currentResults = [...currentResults, ...issues];
 

server/util/aria.js

@@ -28,6 +28,7 @@ const testWithModifiedAttributes = (test, { forUpdateCompare }) => {
     // The updated settings, instructions or references should be shown when
     // the copy process is done
     propertiesToOmit.push('renderableContent.target.at.settings');
+    propertiesToOmit.push('renderableContent.target.referencePage');
     propertiesToOmit.push('renderableContent.instructions');
     propertiesToOmit.push('renderableContent.info.references');
     // for v1 format since structure is: