Skip to content

Should selection start/end be limited to the size of the text? #88

Open
@dandclark

Description

@dandclark

While looking at #87 I noticed that updateSelection() as currently specified doesn't prevent the author from specifying a selection that's outside the bounds of the text.

This is not what I would have expected; it seems like a potential source of errors to allow selection to be set outside of the text. It's not exactly clear how the browser should handle adjusting selection in these scenarios.

We should consider enforcing that updateSelection() not allow the author to set a selection begin or end larger than the size of EditContext.text.

If we add this restriction, we'd also want to have updateText() adjust the selection offsets if the update would put them outside of the new shortened text.

The current Chromium implementation clamps the selection set in updateSelection() to the length of the text, but does not throw an error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions