links: don't check favicon.ico if it's not provided

Author: deniak

lib/rules/links/linkchecker.js

@@ -84,39 +84,42 @@ export async function check(sr, done) {
     });
     const page = await browser.newPage();
     const docPath = sr.url.replace(/\/[^/]+$/, '/').replace(/^https?:/, '');
+    const origin = new URL(sr.url).origin;
 
     page.on('response', response => {
         const url = simplifyURL(response.url());
         const { referer } = response.request().headers();
 
-        // check if resource is in same folder as base document
-        if (
-            !url.replace(/^https?:/, '').startsWith(docPath) &&
-            !(includedByReg(url) || includedByReg(referer)) &&
-            url !== sr.url
-        ) {
-            sr.error(compound, 'not-same-folder', { base: docPath, url });
-        }
+        if (url !== `${origin}/favicon.ico`) {
+            // check if resource is in same folder as base document
+            if (
+                !url.replace(/^https?:/, '').startsWith(docPath) &&
+                !(includedByReg(url) || includedByReg(referer)) &&
+                url !== sr.url
+            ) {
+                sr.error(compound, 'not-same-folder', { base: docPath, url });
+            }
 
-        // check if every resource's status code is ok, ignore 3xx
-        if (response.status() >= 400 && !noRespondAllowList.includes(url)) {
-            const chain = response.request().redirectChain();
-            // If an url is redirected from another, chain shall exist
-            if (chain.length) {
-                sr.error(compound, 'response-error-with-redirect', {
-                    url,
-                    originUrl: chain[0].url(),
-                    status: response.status(),
-                    text: response.statusText(),
-                    referer,
-                });
-            } else {
-                sr.error(compound, 'response-error', {
-                    url,
-                    status: response.status(),
-                    text: response.statusText(),
-                    referer,
-                });
+            // check if every resource's status code is ok, ignore 3xx
+            if (response.status() >= 400 && !noRespondAllowList.includes(url)) {
+                const chain = response.request().redirectChain();
+                // If an url is redirected from another, chain shall exist
+                if (chain.length) {
+                    sr.error(compound, 'response-error-with-redirect', {
+                        url,
+                        originUrl: chain[0].url(),
+                        status: response.status(),
+                        text: response.statusText(),
+                        referer,
+                    });
+                } else {
+                    sr.error(compound, 'response-error', {
+                        url,
+                        status: response.status(),
+                        text: response.statusText(),
+                        referer,
+                    });
+                }
             }
         }
     });