Feat: sponsor test 코드 작성 & sponsor 코드 수정 (#100)

- sponsor 테스트 코드를 작성했습니다
- sponsor api 코드를 수정했습니다
    - amount 자료형을 int으로 하고,  sponsored_date의 자료형을 Date로 바꿨습니다
    - 제가 그 당시에 코드를 대충 짰나 봅니다 ㅠㅠ

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- Refactor
  - Standardized sponsor amount to an integer value.
  - Sponsored date is now date-only (no time/timezone).
  - API endpoints now accept numeric sponsor IDs instead of strings.
- Tests
- Added comprehensive tests for sponsor creation, retrieval, listing,
and updates.
- Chores
  - Database schema updated to align column types with the new formats.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: deveroskp

wacruit/src/apps/sponsor/models.py

@@ -1,6 +1,6 @@
-from datetime import datetime
+from datetime import date
 
-from sqlalchemy import DateTime
+from sqlalchemy import Date
 from sqlalchemy.orm import Mapped
 from sqlalchemy.orm import mapped_column
 
@@ -14,7 +14,7 @@ class Sponsor(DeclarativeBase):
 
     id: Mapped[intpk]
     name: Mapped[str30]
-    amount: Mapped[str30]
+    amount: Mapped[int]
     email: Mapped[str30 | None]
     phone_number: Mapped[str30 | None]
-    sponsored_date: Mapped[datetime] = mapped_column(DateTime(timezone=True))
+    sponsored_date: Mapped[date] = mapped_column(Date)

wacruit/src/apps/sponsor/repositories.py

@@ -23,7 +23,7 @@ def create_sponsor(self, sponsor: Sponsor):
     def get_sponsor_by_sponsor_name(self, sponsor_name: str) -> Sponsor | None:
         return self.session.query(Sponsor).filter(Sponsor.name == sponsor_name).first()
 
-    def get_sponsor_by_id(self, sponsor_id: str) -> Sponsor | None:
+    def get_sponsor_by_id(self, sponsor_id: int) -> Sponsor | None:
         return self.session.query(Sponsor).filter(Sponsor.id == sponsor_id).first()
 
     def get_all_sponsors(self) -> list[Sponsor]:

wacruit/src/apps/sponsor/services.py

@@ -29,7 +29,7 @@ def create_sponsor(self, request: SponsorCreateRequest):
         )
         return self.sponsor_repository.create_sponsor(sponsor)
 
-    def get_sponsor_by_id(self, sponsor_id: str) -> SponsorInfoResponse:
+    def get_sponsor_by_id(self, sponsor_id: int) -> SponsorInfoResponse:
         sponsor = self.sponsor_repository.get_sponsor_by_id(sponsor_id)
         if not sponsor:
             raise SponsorNotFoundException
@@ -46,7 +46,7 @@ def get_all_sponsors(self) -> ListResponse[SponsorBriefResponse]:
         )
 
     def update_sponsor(
-        self, sponsor_id: str, request: SponsorUpdateRequest
+        self, sponsor_id: int, request: SponsorUpdateRequest
     ) -> SponsorInfoResponse:
         sponsor = self.sponsor_repository.get_sponsor_by_id(sponsor_id)
         if not sponsor:

wacruit/src/apps/sponsor/views.py

@@ -27,7 +27,7 @@ def create_sponsor(
 @v3_router.get("/{sponsor_id}")
 def get_sponsor(
     admin_user: AdminUser,
-    sponsor_id: str,
+    sponsor_id: int,
     sponsor_service: Annotated[SponsorService, Depends()],
 ) -> SponsorInfoResponse:
     return sponsor_service.get_sponsor_by_id(sponsor_id)
@@ -43,7 +43,7 @@ def get_all_sponsors(
 @v3_router.patch("/{sponsor_id}")
 def update_sponsor(
     admin_user: AdminUser,
-    sponsor_id: str,
+    sponsor_id: int,
     request: SponsorUpdateRequest,
     sponsor_service: Annotated[SponsorService, Depends()],
 ) -> SponsorInfoResponse:

wacruit/src/database/migrations/versions/2025_08_25_2136-16b579609e97_fix_sponsor_amount_sponsored_date_type.py

@@ -0,0 +1,40 @@
+"""fix sponsor amount & sponsored_date type
+
+Revision ID: 16b579609e97
+Revises: 4869ce051b80
+Create Date: 2025-08-25 21:36:23.655109
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects import mysql
+
+# revision identifiers, used by Alembic.
+revision = "16b579609e97"
+down_revision = "4869ce051b80"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "sponsor",
+        "amount",
+        existing_type=mysql.VARCHAR(length=30),
+        type_=sa.Integer(),
+        existing_nullable=False,
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "sponsor",
+        "amount",
+        existing_type=sa.Integer(),
+        type_=mysql.VARCHAR(length=30),
+        existing_nullable=False,
+    )
+    # ### end Alembic commands ###

wacruit/src/database/migrations/versions/2025_08_25_2142-f1532cef4ac5_fix_sponsored_date_type.py

@@ -0,0 +1,40 @@
+"""fix sponsored_date type
+
+Revision ID: f1532cef4ac5
+Revises: 16b579609e97
+Create Date: 2025-08-25 21:42:00.063456
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects import mysql
+
+# revision identifiers, used by Alembic.
+revision = "f1532cef4ac5"
+down_revision = "16b579609e97"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "sponsor",
+        "sponsored_date",
+        existing_type=mysql.DATETIME(),
+        type_=sa.Date(),
+        existing_nullable=False,
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "sponsor",
+        "sponsored_date",
+        existing_type=sa.Date(),
+        type_=mysql.DATETIME(),
+        existing_nullable=False,
+    )
+    # ### end Alembic commands ###

wacruit/src/tests/sponsor/conftest.py

@@ -0,0 +1,89 @@
+import datetime
+from typing import List
+
+from pydantic import EmailStr
+import pytest
+from sqlalchemy.orm import Session
+
+from wacruit.src.apps.sponsor.models import Sponsor
+from wacruit.src.apps.sponsor.repositories import SponsorRepository
+from wacruit.src.apps.sponsor.schemas import SponsorCreateRequest
+from wacruit.src.apps.sponsor.schemas import SponsorUpdateRequest
+from wacruit.src.apps.sponsor.services import SponsorService
+from wacruit.src.database.connection import Transaction
+
+
+@pytest.fixture
+def sponsor_repository(db_session: Session) -> SponsorRepository:
+    return SponsorRepository(session=db_session, transaction=Transaction(db_session))
+
+
+@pytest.fixture
+def sponsor_service(sponsor_repository: SponsorRepository) -> SponsorService:
+    return SponsorService(sponsor_repository=sponsor_repository)
+
+
+@pytest.fixture
+def created_sponsor(db_session: Session) -> Sponsor:
+    sponsor = Sponsor(
+        name="김와플",
+        amount=50000,
+        email="waffle@snu.ac.kr",
+        phone_number="010-1234-5678",
+        sponsored_date=datetime.date(2025, 1, 1),
+    )
+    db_session.add(sponsor)
+    db_session.commit()
+    return sponsor
+
+
+@pytest.fixture
+def created_sponsor_list(db_session: Session) -> List[Sponsor]:
+    sponsors = [
+        Sponsor(
+            name="김와플",
+            amount=50000,
+            email="waffle1@snu.ac.kr",
+            phone_number="010-1111-1111",
+            sponsored_date=datetime.date(2025, 1, 1),
+        ),
+        Sponsor(
+            name="이와플",
+            amount=200000,
+            email="waffle2@snu.ac.kr",
+            phone_number="010-2222-2222",
+            sponsored_date=datetime.date(2025, 1, 1),
+        ),
+        Sponsor(
+            name="최와플",
+            amount=300000,
+            email="waffle3@snu.ac.kr",
+            phone_number="010-3333-3333",
+            sponsored_date=datetime.date(2025, 1, 1),
+        ),
+    ]
+
+    db_session.add_all(sponsors)
+    db_session.commit()
+
+    return sponsors
+
+
+@pytest.fixture
+def sponsor_create_dto():
+    return SponsorCreateRequest(
+        name="김와플",
+        amount=100000,
+        sponsored_date=datetime.date(2025, 1, 1),
+        email=EmailStr("waffle@snu.ac.kr"),
+        phone_number="010-1234-5678",
+    )
+
+
+@pytest.fixture
+def sponsor_update_dto():
+    return SponsorUpdateRequest(
+        amount=1000000,
+        email=EmailStr("waffle3@snu.ac.kr"),
+        phone_number="010-2222-3333",
+    )

wacruit/src/tests/sponsor/test_sponsor_service.py

@@ -0,0 +1,69 @@
+from typing import List
+
+import pytest
+
+from wacruit.src.apps.sponsor.exceptions import SponsorAlreadyExistsException
+from wacruit.src.apps.sponsor.exceptions import SponsorNotFoundException
+from wacruit.src.apps.sponsor.models import Sponsor
+from wacruit.src.apps.sponsor.schemas import SponsorCreateRequest
+from wacruit.src.apps.sponsor.schemas import SponsorUpdateRequest
+from wacruit.src.apps.sponsor.services import SponsorService
+
+
+def test_create_sponsor(
+    sponsor_service: SponsorService, sponsor_create_dto: SponsorCreateRequest
+):
+    created_sponsor = sponsor_service.create_sponsor(sponsor_create_dto)
+
+    assert created_sponsor.id is not None
+    assert created_sponsor.name == sponsor_create_dto.name
+    assert created_sponsor.email == sponsor_create_dto.email
+    assert created_sponsor.phone_number == sponsor_create_dto.phone_number
+    assert created_sponsor.sponsored_date == sponsor_create_dto.sponsored_date
+
+
+def test_create_duplicate_sponsor(
+    sponsor_service: SponsorService, sponsor_create_dto: SponsorCreateRequest
+):
+    sponsor_service.create_sponsor(sponsor_create_dto)
+    with pytest.raises(SponsorAlreadyExistsException):
+        sponsor_service.create_sponsor(sponsor_create_dto)
+
+
+def test_get_sponsor_by_existing_id(
+    sponsor_service: SponsorService, created_sponsor: Sponsor
+):
+    sponsor = sponsor_service.get_sponsor_by_id(created_sponsor.id)
+    assert sponsor.id == created_sponsor.id
+    assert sponsor.name == created_sponsor.name
+    assert sponsor.amount == created_sponsor.amount
+    assert sponsor.email == created_sponsor.email
+    assert sponsor.phone_number == created_sponsor.phone_number
+    assert sponsor.sponsored_date == created_sponsor.sponsored_date
+
+
+def test_get_sponsor_by_non_existing_id(sponsor_service: SponsorService):
+    with pytest.raises(SponsorNotFoundException):
+        sponsor_service.get_sponsor_by_id(1234)
+
+
+def test_get_all_sponsors(
+    sponsor_service: SponsorService, created_sponsor_list: List[Sponsor]
+):
+    sponsors = sponsor_service.get_all_sponsors()
+    assert len(sponsors.items) == len(created_sponsor_list)
+    for i in range(3):
+        assert sponsors.items[i].name == created_sponsor_list[i].name
+
+
+def test_update_sponsor(
+    sponsor_service: SponsorService,
+    sponsor_create_dto: SponsorCreateRequest,
+    sponsor_update_dto: SponsorUpdateRequest,
+):
+    sponsor = sponsor_service.create_sponsor(sponsor_create_dto)
+    assert sponsor.id is not None
+    updated_sponsor = sponsor_service.update_sponsor(sponsor.id, sponsor_update_dto)
+    assert updated_sponsor.amount == sponsor_update_dto.amount
+    assert updated_sponsor.email == sponsor_update_dto.email
+    assert updated_sponsor.phone_number == sponsor_update_dto.phone_number