Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap to version 5 #254

Open
lb- opened this issue Mar 11, 2023 · 4 comments
Open

Upgrade Bootstrap to version 5 #254

lb- opened this issue Mar 11, 2023 · 4 comments

Comments

@lb-
Copy link
Member

lb- commented Mar 11, 2023

Currently the Theme is using Bootstrap 4 and it would be good to upgrade to version 5.

Split from #252 / #250

Bootstrap 5 did remove jquery as a dependency. Not sure how broken that would be to upgrade, or if it would be a mostly drop-in replacement given our minimal bootstrap usage. https://getbootstrap.com/docs/5.2/migration/
Originally posted by @vsalvino in #252 (comment)

It may be worth considering a small clean up of unused styles in the process. See #64

@dassudip2001
Copy link

it used Bootstrap CDN ??

@lb-
Copy link
Member Author

lb- commented Mar 12, 2023

@dassudip2001
Copy link

dassudip2001 commented Mar 13, 2023

Screenshot from 2023-03-13 09-44-18

i can fix it ? can i send a PR

@lb-
Copy link
Member Author

lb- commented Mar 10, 2024

Just a thought. Is it worth looking at something more lightweight instead of Bootstrap.

Maybe too lightweight - https://open-props.style/ - but super flexible with CSS Custom Properties as the core method of designs.

Not sure on other options, maybe we need to review the actual Bootstrap parts used.

Also need to consider the ability to customise and override things for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants