We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 2b0c860 commit 0920b24Copy full SHA for 0920b24
2 files changed
app/models/item.rb
@@ -83,7 +83,7 @@ def calculation_formula_must_be_valid
83
84
def check_all_formula_parameters_present
85
missing_parameters = formula_parameters.reject do |param|
86
- calculation_formula.include?(param)
+ calculation_formula.match?(/\b#{Regexp.escape(param)}\b/)
87
end
88
89
return unless missing_parameters.any?
spec/models/item_spec.rb
@@ -109,7 +109,7 @@
109
110
111
it 'is invalid if all formula_parameters are missing in formula' do
112
- item.calculation_formula = 'param1 + 123'
+ item.calculation_formula = 'param1 + 123 + param212'
113
expect(item).not_to be_valid
114
expect(item.errors[:calculation_formula]).to include('is missing parameters: param2')
115
0 commit comments