PC-24: Remove item_pricing association from QuoteItem and related files

Author: OGoncharenko

app/admin/quotes.rb

@@ -4,7 +4,6 @@
                                          :_destroy,
                                          :quote_id,
                                          :item_id,
-                                         :item_pricing_id,
                                          :open_parameters,
                                          :price,
                                          :discount,
@@ -40,7 +39,6 @@
     f.inputs "Quote Items" do
       f.has_many :quote_items, allow_destroy: true, new_record: true do |qi|
         qi.input :item, as: :select, collection: Item.pluck(:name, :id)
-        qi.input :item_pricing, as: :select, collection: ItemPricing.pluck(:default_fixed_price, :id)
         qi.input :open_parameters
         qi.input :price
         qi.input :discount
@@ -63,7 +61,6 @@
     panel 'Quote Items' do
       table_for quote.quote_items do
         column :item
-        column :item_pricing
         column :open_parameters
         column :price
         column :discount

app/models/quote_item.rb

@@ -1,7 +1,6 @@
 class QuoteItem < ApplicationRecord
   belongs_to :quote
   belongs_to :item
-  belongs_to :item_pricing
 
   validates :price, presence: true, numericality: { greater_than_or_equal_to: 0 }
   validates :discount, numericality: { greater_than_or_equal_to: 0, less_than_or_equal_to: 100 }
@@ -23,7 +22,6 @@ def should_recalculate_final_price?
   end
 
   def recalculate_quote_total_price
-    # quote.update(total_price: quote.quote_items.sum(:final_price))
     quote.recalculate_total_price
   end
 end

…ate/20250320050959_create_quote_items.rb …ate/20250401050959_create_quote_items.rbdb/migrate/20250320050959_create_quote_items.rb renamed to db/migrate/20250401050959_create_quote_items.rb db/migrate/20250320050959_create_quote_items.rb renamed to db/migrate/20250401050959_create_quote_items.rb

@@ -3,7 +3,6 @@ def change
     create_table :quote_items do |t|
       t.references :quote, null: false, foreign_key: true
       t.references :item, null: false, foreign_key: true
-      t.references :item_pricing, null: false, foreign_key: true
       t.jsonb :open_parameters, default: {}
       t.decimal :price, precision: 10, scale: 2, null: false
       t.decimal :discount, precision: 5, scale: 2, default: 0.00, null: false

db/schema.rb

@@ -2,7 +2,6 @@
   factory :quote_item do
     association :quote, factory: :quote
     association :item, factory: :item
-    association :item_pricing, factory: :item_pricing
     price { 100.00 }
     discount { 10 }
     open_parameters { {} }

spec/factories/item_pricings.rb

@@ -4,7 +4,6 @@
   describe 'associations' do
     it { is_expected.to belong_to(:quote).required }
     it { is_expected.to belong_to(:item).required }
-    it { is_expected.to belong_to(:item_pricing).required }
   end
 
   describe 'validations' do
@@ -21,14 +20,13 @@
 
   describe 'before_save callbacks' do
     let(:quote) { create(:quote) }
-    let(:item) { create(:item, pricing_type: :open) }
-    let(:item_pricing) { create(:item_pricing, item: item) }
+    let(:item) { create(:item) }
     let(:price) { 1000 }
     let(:discount) { 10 }
 
     context 'when quote_item is created' do
       let(:quote_item) do
-        QuoteItem.new(quote: quote, item_pricing: item_pricing, item: item, price: price, discount: discount)
+        QuoteItem.new(quote: quote, item: item, price: price, discount: discount)
       end
 
       it 'calculates final_price before saving' do
@@ -39,7 +37,7 @@
 
     context 'when quote_item is updated' do
       let(:quote_item) do
-        create(:quote_item, quote: quote, item_pricing: item_pricing, item: item, price: price, discount: discount)
+        create(:quote_item, quote: quote, item: item, price: price, discount: discount)
       end
 
       context 'when price changes' do
@@ -90,9 +88,8 @@
 
   describe 'after_save callbacks' do
     let(:quote) { create(:quote) }
-    let(:item) { create(:item, pricing_type: :open) }
-    let(:item_pricing) { create(:item_pricing, item: item) }
-    let(:quote_item) { build(:quote_item, quote: quote, item_pricing: item_pricing, item: item) }
+    let(:item) { create(:item, :with_pricing_options) }
+    let(:quote_item) { build(:quote_item, quote: quote, item: item) }
 
     it 'recalculates quote total_price after saving' do
       expect(quote).to receive(:recalculate_total_price)