PC-27: Render only enabled category and items

Author: PivtoranisV

app/admin/quotes.rb

@@ -37,9 +37,9 @@
       f.input :customer, as: :select, collection: Customer.pluck(:company_name, :id)
       f.input :user, as: :select, collection: User.order(:name).pluck(:name, :id)
       f.input :categories, as: :check_boxes,
-                           collection: Category.order(:name).pluck(:name, :id),
+                           collection: Category.enabled.order(:name).pluck(:name, :id),
                            wrapper_html: { class: 'categories-wrapper' }
-      f.input :item_ids, label: 'Items Without Category', as: :check_boxes, collection: Item.where(category_id: nil).order(:name),
+      f.input :item_ids, label: 'Items Without Category', as: :check_boxes, collection: Item.enabled.where(category_id: nil).order(:name),
                          wrapper_html: { class: 'categories-wrapper' }
       f.input :total_price, as: :number, input_html: { min: 0, readonly: true }, hint: 'Total price will be calculated automatically based on quote items.'
     end

app/models/category.rb

@@ -19,6 +19,8 @@ class Category < ApplicationRecord
                              message: "must contain only ASCII characters" },
                    if: -> { name.present? }
 
+  scope :enabled, -> { where(is_disabled: false) }
+
   def self.ransackable_attributes(_auth_object = nil)
     %w[created_at description id id_value is_disabled name updated_at]
   end

app/models/item.rb

@@ -10,6 +10,8 @@ class Item < ApplicationRecord
   validates :calculation_formula, presence: true, if: :requires_calculation_formula?
   validates_with ItemFormulaSyntaxValidator
 
+  scope :enabled, -> { where(is_disabled: false) }
+
   def self.ransackable_attributes(_auth_object = nil)
     %w[category_id created_at id is_disabled name updated_at]
   end

spec/requests/admin/quotes_controller_spec.rb

@@ -19,10 +19,11 @@
     it "renders the index page successfully" do
       get admin_quotes_path
       expect(response).to be_successful
-      expect(response.body).to include("Quotes")
-      expect(response.body).to include(customer.company_name)
-      expect(response.body).to include(user.name)
-      expect(response.body).to include(quote.total_price.to_s)
+      unescaped_body = CGI.unescapeHTML(response.body)
+      expect(unescaped_body).to include("Quotes")
+      expect(unescaped_body).to include(customer.company_name)
+      expect(unescaped_body).to include(user.name)
+      expect(unescaped_body).to include(quote.total_price.to_s)
     end
   end