PC-24: Fixed lint and specs

Author: PivtoranisV

app/models/categorization.rb

@@ -0,0 +1,4 @@
+class Categorization < ApplicationRecord
+  belongs_to :quote
+  belongs_to :category
+end

app/models/category.rb

@@ -2,7 +2,8 @@ class Category < ApplicationRecord
   ASCII_CHARACTERS = /\A[[:ascii:]]*\z/
 
   has_many :items, dependent: :nullify
-  has_and_belongs_to_many :quotes
+  has_many :categorizations, dependent: :destroy
+  has_many :quotes, through: :categorizations
 
   normalizes :name, with: ->(name) { name.gsub(/\s+/, ' ').strip }
 

app/models/quote.rb

@@ -2,7 +2,8 @@ class Quote < ApplicationRecord
   belongs_to :customer
   belongs_to :user
   has_many :quote_items, dependent: :destroy
-  has_and_belongs_to_many :categories
+  has_many :categorizations, dependent: :destroy
+  has_many :categories, through: :categorizations
 
   validates :total_price, presence: true, numericality: { greater_than_or_equal_to: 0 }
 

db/migrate/20250423145035_create_join_table_quotes_categories.rb

@@ -0,0 +1,10 @@
+class CreateCategorizations < ActiveRecord::Migration[8.0]
+  def change
+    create_table :categorizations do |t|
+      t.references :quote, null: false, foreign_key: true
+      t.references :category, null: false, foreign_key: true
+
+      t.timestamps
+    end
+  end
+end

db/migrate/20250424093006_create_categorizations.rb

@@ -4,6 +4,6 @@
     association :item, factory: :item
     price { 100.00 }
     discount { 10 }
-    open_parameters { {} }
+    pricing_parameters { {} }
   end
 end

db/schema.rb

@@ -1,13 +1,13 @@
 require 'rails_helper'
 
 RSpec.describe Customer, type: :model do
+  subject { build(:customer) }
+
   describe 'associations' do
     it { is_expected.to have_many(:quotes).dependent(:destroy) }
   end
 
   describe 'validations' do
-    let(:customer) { build(:customer) }
-
     it { is_expected.to be_valid }
 
     describe 'company_name' do