PC-50: Add validation for pricing option with value_label

Author: PivtoranisV

app/assets/javascripts/active_admin.js

@@ -73,7 +73,7 @@ document.addEventListener("DOMContentLoaded", function () {
         category_id: categoryField?.value || ""
       };
 
-      const itemId = link.dataset.itemId || "new"; // 💡 правильний спосіб
+      const itemId = link.dataset.itemId || "new";
 
       fetch(`/admin/items/${itemId}/save_meta_to_session`, {
         method: "POST",
@@ -84,7 +84,7 @@ document.addEventListener("DOMContentLoaded", function () {
         body: JSON.stringify(data)
       }).then(response => {
         if (response.ok) {
-          window.location.href = link.dataset.redirect; // 💥 редірект тільки після успіху
+          window.location.href = link.dataset.redirect;
         } else {
           alert("⚠️ Failed to save temporary data to session");
         }
@@ -162,7 +162,6 @@ document.addEventListener("DOMContentLoaded", () => {
       <button type="button" class="delete-option-button button light">Delete</button>
     `;
 
-    // кнопка Delete
     row.querySelector(".delete-option-button").addEventListener("click", () => {
       if (wrapper.querySelectorAll(".select-option-row").length > 2) {
         row.remove();
@@ -174,13 +173,12 @@ document.addEventListener("DOMContentLoaded", () => {
     return row;
   };
 
-  // Додати новий рядок
   addBtn.addEventListener("click", () => {
     const newRow = createOptionRow();
     wrapper.appendChild(newRow);
   });
 
-  // Додати обробники на існуючі 2 рядки
+
   wrapper.querySelectorAll(".select-option-row").forEach((row) => {
     const delBtn = row.querySelector(".delete-option-button");
     delBtn.addEventListener("click", () => {

app/models/item.rb

@@ -5,7 +5,7 @@ class Item < ApplicationRecord
   validates :name, uniqueness: { scope: :category_id, message: "Item name must be unique within category" }
   validate :category_must_be_active
   validate :fixed_parameters_values_must_be_numeric
-  # validate :pricing_options_values_must_be_numeric
+  validate :pricing_options_values_must_be_numeric
   validates :calculation_formula, presence: true, if: :requires_calculation_formula?
 
   def self.ransackable_attributes(_auth_object = nil)
@@ -29,26 +29,29 @@ def fixed_parameters_values_must_be_numeric
   end
 
   def pricing_options_values_must_be_numeric
-    validate_jsonb_numeric_values(:pricing_options)
+    validate_jsonb_numeric_values(:pricing_options) do |key_path, val|
+      key_path.last != 'value_label' && !numeric?(val)
+    end
   end
 
-  def validate_jsonb_numeric_values(attribute)
+  def validate_jsonb_numeric_values(attribute, &block)
     value = self[attribute] || {}
     unless value.is_a?(Hash)
       errors.add(attribute, "must be a JSON object")
       return
     end
 
-    validate_nested_numeric_values(value, attribute)
+    validate_nested_numeric_values(value, attribute, [], &block)
   end
 
-  def validate_nested_numeric_values(hash, attribute, key_path = [])
+  def validate_nested_numeric_values(hash, attribute, key_path = [], &block)
     hash.each do |key, val|
       current_path = key_path + [key]
       if val.is_a?(Hash)
-        validate_nested_numeric_values(val, attribute, current_path)
+        validate_nested_numeric_values(val, attribute, current_path, &block)
       else
-        errors.add(attribute, "value for '#{current_path.join(' -> ')}' must be a number") unless numeric?(val)
+        should_error = block_given? ? yield(current_path, val) : !numeric?(val)
+        errors.add(attribute, "value for '#{current_path.join(' -> ')}' must be a number") if should_error
       end
     end
   end