Skip to content

Commit 5d3144a

Browse files
leaanthonyclaude
andcommitted
More Go 1.25 vet fixes for windows-only code paths
- internal/frontend/desktop/windows/frontend.go: 5 more logger.Error(fmt.Sprintf("...", args...)) sites switched to direct logger.Error("...", args...) printf-style. These didn't match my earlier sed because the format strings have multiple args (not just err.Error()). - internal/wv2installer/{download.go,wv2installer.go}: drop the now- unused "fmt" import after the previous switch from fmt.Errorf to errors.New. GOOS=windows go vet ./... locally clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent f33ce4c commit 5d3144a

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

v2/internal/frontend/desktop/windows/frontend.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -698,13 +698,13 @@ var edgeMap = map[string]uintptr{
698698
func (f *Frontend) processMessage(message string, sender *edge.ICoreWebView2, args *edge.ICoreWebView2WebMessageReceivedEventArgs) {
699699
topSource, err := sender.GetSource()
700700
if err != nil {
701-
f.logger.Error(fmt.Sprintf("Unable to get source from sender: %s", err.Error()))
701+
f.logger.Error("Unable to get source from sender: %s", err.Error())
702702
return
703703
}
704704

705705
senderSource, err := args.GetSource()
706706
if err != nil {
707-
f.logger.Error(fmt.Sprintf("Unable to get source from args: %s", err.Error()))
707+
f.logger.Error("Unable to get source from args: %s", err.Error())
708708
return
709709
}
710710

@@ -759,13 +759,13 @@ func (f *Frontend) processMessage(message string, sender *edge.ICoreWebView2, ar
759759
func (f *Frontend) processMessageWithAdditionalObjects(message string, sender *edge.ICoreWebView2, args *edge.ICoreWebView2WebMessageReceivedEventArgs) {
760760
topSource, err := sender.GetSource()
761761
if err != nil {
762-
f.logger.Error(fmt.Sprintf("Unable to get source from sender: %s", err.Error()))
762+
f.logger.Error("Unable to get source from sender: %s", err.Error())
763763
return
764764
}
765765

766766
senderSource, err := args.GetSource()
767767
if err != nil {
768-
f.logger.Error(fmt.Sprintf("Unable to get source from args: %s", err.Error()))
768+
f.logger.Error("Unable to get source from args: %s", err.Error())
769769
return
770770
}
771771

@@ -835,7 +835,7 @@ func (f *Frontend) processMessageWithAdditionalObjects(message string, sender *e
835835
func (f *Frontend) validBindingOrigin(source string) bool {
836836
origin, err := f.originValidator.GetOriginFromURL(source)
837837
if err != nil {
838-
f.logger.Error(fmt.Sprintf("Error parsing source URL %s: %v", source, err.Error()))
838+
f.logger.Error("Error parsing source URL %s: %v", source, err.Error())
839839
return false
840840
}
841841
allowed := f.originValidator.IsOriginAllowed(origin)

v2/internal/wv2installer/download.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ package wv2installer
55

66
import (
77
"errors"
8-
"fmt"
98

109
"github.com/wailsapp/wails/v2/internal/webview2runtime"
1110
"github.com/wailsapp/wails/v2/pkg/options/windows"

v2/internal/wv2installer/wv2installer.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ package wv2installer
44

55
import (
66
"errors"
7-
"fmt"
87

98
"github.com/wailsapp/go-webview2/webviewloader"
109
"github.com/wailsapp/wails/v2/pkg/options"

0 commit comments

Comments
 (0)