Skip to content

Commit 7a79637

Browse files
committed
ci: scope apt cache keys by job and runner arch (review feedback)
test_go and test_templates install different GTK4 package sets but shared a key slug, so whichever job saved first left the other permanently re-downloading its extras; and the cross-compile matrix pins per-leg runners, so arch-mismatched archives could be restored. Keys and restore prefixes now include github.job and runner.arch.
1 parent 05a3979 commit 7a79637

4 files changed

Lines changed: 18 additions & 18 deletions

File tree

.github/workflows/build-and-test-v3.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,9 @@ jobs:
113113
uses: actions/cache@v4
114114
with:
115115
path: ~/.apt-archives
116-
key: apt-install-linux-dependencies-gtk4-default--${{ github.run_id }}
116+
key: apt-install-linux-dependencies-gtk4-default--${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
117117
restore-keys: |
118-
apt-install-linux-dependencies-gtk4-default--
118+
apt-install-linux-dependencies-gtk4-default--${{ github.job }}-${{ runner.arch }}-
119119
120120
- name: Install linux dependencies (GTK4 default)
121121
if: matrix.os == 'ubuntu-latest'
@@ -237,9 +237,9 @@ jobs:
237237
uses: actions/cache@v4
238238
with:
239239
path: ~/.apt-archives
240-
key: apt-install-linux-dependencies-gtk4-default--${{ github.run_id }}
240+
key: apt-install-linux-dependencies-gtk4-default--${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
241241
restore-keys: |
242-
apt-install-linux-dependencies-gtk4-default--
242+
apt-install-linux-dependencies-gtk4-default--${{ github.job }}-${{ runner.arch }}-
243243
244244
- name: Install linux dependencies (GTK4 default)
245245
if: matrix.os == 'ubuntu-latest'

.github/workflows/build-and-test.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ jobs:
2929
uses: actions/cache@v4
3030
with:
3131
path: ~/.apt-archives
32-
key: apt-install-apt-packages-ubuntu-22-04-libgtk-${{ github.run_id }}
32+
key: apt-install-apt-packages-ubuntu-22-04-libgtk-${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
3333
restore-keys: |
34-
apt-install-apt-packages-ubuntu-22-04-libgtk-
34+
apt-install-apt-packages-ubuntu-22-04-libgtk-${{ github.job }}-${{ runner.arch }}-
3535
3636
- name: Install apt packages (ubuntu-22.04)
3737
if: matrix.os == 'ubuntu-22.04'
@@ -46,9 +46,9 @@ jobs:
4646
uses: actions/cache@v4
4747
with:
4848
path: ~/.apt-archives
49-
key: apt-install-apt-packages-ubuntu-24-04-libgtk-${{ github.run_id }}
49+
key: apt-install-apt-packages-ubuntu-24-04-libgtk-${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
5050
restore-keys: |
51-
apt-install-apt-packages-ubuntu-24-04-libgtk-
51+
apt-install-apt-packages-ubuntu-24-04-libgtk-${{ github.job }}-${{ runner.arch }}-
5252
5353
- name: Install apt packages (ubuntu-24.04)
5454
if: matrix.os == 'ubuntu-24.04'
@@ -154,9 +154,9 @@ jobs:
154154
uses: actions/cache@v4
155155
with:
156156
path: ~/.apt-archives
157-
key: apt-install-apt-packages-ubuntu-22-04-libgtk-${{ github.run_id }}
157+
key: apt-install-apt-packages-ubuntu-22-04-libgtk-${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
158158
restore-keys: |
159-
apt-install-apt-packages-ubuntu-22-04-libgtk-
159+
apt-install-apt-packages-ubuntu-22-04-libgtk-${{ github.job }}-${{ runner.arch }}-
160160
161161
- name: Install apt packages (ubuntu-22.04)
162162
if: matrix.os == 'ubuntu-22.04'
@@ -175,9 +175,9 @@ jobs:
175175
uses: actions/cache@v4
176176
with:
177177
path: ~/.apt-archives
178-
key: apt-install-apt-packages-ubuntu-24-04-libgtk-${{ github.run_id }}
178+
key: apt-install-apt-packages-ubuntu-24-04-libgtk-${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
179179
restore-keys: |
180-
apt-install-apt-packages-ubuntu-24-04-libgtk-
180+
apt-install-apt-packages-ubuntu-24-04-libgtk-${{ github.job }}-${{ runner.arch }}-
181181
182182
- name: Install apt packages (ubuntu-24.04)
183183
if: matrix.os == 'ubuntu-24.04'

.github/workflows/cross-compile-test-v3.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ jobs:
9595
uses: actions/cache@v4
9696
with:
9797
path: ~/.apt-archives
98-
key: apt-cross-compile-${{ github.run_id }}
98+
key: apt-cross-compile-${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
9999
restore-keys: |
100-
apt-cross-compile-
100+
apt-cross-compile-${{ github.job }}-${{ runner.arch }}-
101101
102102
- name: Install Linux dependencies
103103
run: |

.github/workflows/pr-master.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ jobs:
7070
uses: actions/cache@v4
7171
with:
7272
path: ~/.apt-archives
73-
key: apt-install-linux-dependencies-22-04-libgtk--${{ github.run_id }}
73+
key: apt-install-linux-dependencies-22-04-libgtk--${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
7474
restore-keys: |
75-
apt-install-linux-dependencies-22-04-libgtk--
75+
apt-install-linux-dependencies-22-04-libgtk--${{ github.job }}-${{ runner.arch }}-
7676
7777
- name: Install linux dependencies (22.04)
7878
if: matrix.os == 'ubuntu-22.04'
@@ -87,9 +87,9 @@ jobs:
8787
uses: actions/cache@v4
8888
with:
8989
path: ~/.apt-archives
90-
key: apt-install-linux-dependencies-24-04-libgtk--${{ github.run_id }}
90+
key: apt-install-linux-dependencies-24-04-libgtk--${{ github.job }}-${{ runner.arch }}-${{ github.run_id }}
9191
restore-keys: |
92-
apt-install-linux-dependencies-24-04-libgtk--
92+
apt-install-linux-dependencies-24-04-libgtk--${{ github.job }}-${{ runner.arch }}-
9393
9494
- name: Install linux dependencies (24.04)
9595
if: matrix.os == 'ubuntu-24.04'

0 commit comments

Comments
 (0)