Commit f87ff5b
refactor(v3): fold webview2 module into v3/internal/webview2 (#5711)
The webview2 binding was a separate Go module (github.com/wailsapp/wails/webview2)
whose only consumer is v3. Keeping it separate forced a release dance: tag
webview2, then bump v3's go.mod (automated via a nightly sync workflow) before any
binding change could ship in a v3 release.
Fold it into the v3 module under internal/ (compiler-enforced no external import),
which removes the dance entirely: edit-and-go, single module.
- git mv webview2 -> v3/internal/webview2; drop its go.mod/go.sum
- rewrite import paths in the binding + 11 v3 consumers
- drop ./webview2 from go.work; go mod tidy (go-winloader now direct)
- add missing //go:build windows to 8 edge files that lacked it (latent: the
binding was never part of v3's cross-platform 'go build ./...' before)
- CI: delete release-webview2.yml, remove the webview2-sync step from the v3
nightly, drop webview2/** triggers and webview2/go.sum cache keys
For v4 the plan is to copy the directory in rather than share a module.
Co-authored-by: taliesin-ai <lea.anthony@gmail.com>1 parent 1913ff3 commit f87ff5b
467 files changed
Lines changed: 52 additions & 85 deletions
File tree
- v3
- internal
- assetserver/webview
- capabilities
- doctor
- webview2
- internal/w32
- pkg
- combridge
- edge
- webview2
- scripts
- generator
- testfiles
- types
- templates
- webviewloader
- pkg
- application
- doctor-ng
- w32
- webview2
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| |||
109 | 108 | | |
110 | 109 | | |
111 | 110 | | |
112 | | - | |
| 111 | + | |
113 | 112 | | |
114 | 113 | | |
115 | 114 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
356 | 356 | | |
357 | 357 | | |
358 | 358 | | |
359 | | - | |
360 | | - | |
361 | 359 | | |
362 | 360 | | |
363 | 361 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
File renamed without changes.
File renamed without changes.
File renamed without changes.
0 commit comments