Skip to content

feat!: accept one filed for network configuration #2027

Open
@vpavlin

Description

@vpavlin

This is a bug report

Problem

When contentTopics is specified, options.shardInfo will get populated here https://github.com/waku-org/js-waku/blob/master/packages/sdk/src/utils/libp2p.ts#L98

If shardInfo is specified, pubsubTopics get rewritten https://github.com/waku-org/js-waku/blob/master/packages/sdk/src/utils/libp2p.ts#L105

Proposed Solutions

Either error out if both shardInfo and pubsubTopics is populated, or do not overwrite pubsubTopics if they are explicitly defined

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions