fix: use counter for metrics that only increase over time

Author: chaitanyaprem

Diff for: waku/discovery/waku_discv5.nim

@@ -19,7 +19,7 @@ import
 export protocol, waku_enr
 
 declarePublicGauge waku_discv5_discovered, "number of nodes discovered"
-declarePublicGauge waku_discv5_errors, "number of waku discv5 errors", ["type"]
+declarePublicCounter waku_discv5_errors, "number of waku discv5 errors", ["type"]
 
 logScope:
   topics = "waku discv5"

Diff for: waku/discovery/waku_dnsdisc.nim

@@ -23,7 +23,7 @@ import ../waku_core
 export client
 
 declarePublicGauge waku_dnsdisc_discovered, "number of nodes discovered"
-declarePublicGauge waku_dnsdisc_errors, "number of waku dnsdisc errors", ["type"]
+declarePublicCounter waku_dnsdisc_errors, "number of waku dnsdisc errors", ["type"]
 
 logScope:
   topics = "waku dnsdisc"

Diff for: waku/node/peer_manager/peer_manager.nim

@@ -29,7 +29,7 @@ declareCounter waku_peers_dials, "Number of peer dials", ["outcome"]
 # TODO: Populate from PeerStore.Source when ready
 declarePublicCounter waku_node_conns_initiated,
   "Number of connections initiated", ["source"]
-declarePublicGauge waku_peers_errors, "Number of peer manager errors", ["type"]
+declarePublicCounter waku_peers_errors, "Number of peer manager errors", ["type"]
 declarePublicGauge waku_connected_peers,
   "Number of physical connections per direction and protocol",
   labels = ["direction", "protocol"]

Diff for: waku/node/waku_node.nim

@@ -62,7 +62,7 @@ declarePublicHistogram waku_histogram_message_size,
 
 declarePublicGauge waku_version,
   "Waku version info (in git describe format)", ["version"]
-declarePublicGauge waku_node_errors, "number of wakunode errors", ["type"]
+declarePublicCounter waku_node_errors, "number of wakunode errors", ["type"]
 declarePublicGauge waku_lightpush_peers, "number of lightpush peers"
 declarePublicGauge waku_filter_peers, "number of filter peers"
 declarePublicGauge waku_store_peers, "number of store peers"

Diff for: waku/waku_archive/archive_metrics.nim

@@ -3,8 +3,8 @@
 import metrics
 
 declarePublicGauge waku_archive_messages, "number of historical messages", ["type"]
-declarePublicGauge waku_archive_errors, "number of store protocol errors", ["type"]
-declarePublicGauge waku_archive_queries, "number of store queries received"
+declarePublicCounter waku_archive_errors, "number of store protocol errors", ["type"]
+declarePublicCounter waku_archive_queries, "number of store queries received"
 declarePublicHistogram waku_archive_insert_duration_seconds,
   "message insertion duration"
 declarePublicHistogram waku_archive_query_duration_seconds, "history query duration"

Diff for: waku/waku_archive_legacy/archive_metrics.nim

@@ -7,9 +7,9 @@ import metrics
 
 declarePublicGauge waku_legacy_archive_messages,
   "number of historical messages", ["type"]
-declarePublicGauge waku_legacy_archive_errors,
+declarePublicCounter waku_legacy_archive_errors,
   "number of store protocol errors", ["type"]
-declarePublicGauge waku_legacy_archive_queries, "number of store queries received"
+declarePublicCounter waku_legacy_archive_queries, "number of store queries received"
 declarePublicHistogram waku_legacy_archive_insert_duration_seconds,
   "message insertion duration"
 declarePublicHistogram waku_legacy_archive_query_duration_seconds,

Diff for: waku/waku_filter_v2/protocol_metrics.nim

@@ -4,8 +4,8 @@ import metrics
 
 export metrics
 
-declarePublicGauge waku_filter_errors, "number of filter protocol errors", ["type"]
-declarePublicGauge waku_filter_requests,
+declarePublicCounter waku_filter_errors, "number of filter protocol errors", ["type"]
+declarePublicCounter waku_filter_requests,
   "number of filter subscribe requests received", ["type"]
 declarePublicGauge waku_filter_subscriptions, "number of subscribed filter clients"
 declarePublicHistogram waku_filter_request_duration_seconds,

Diff for: waku/waku_lightpush/protocol_metrics.nim

@@ -2,9 +2,9 @@
 
 import metrics
 
-declarePublicGauge waku_lightpush_v3_errors,
+declarePublicCounter waku_lightpush_v3_errors,
   "number of lightpush protocol errors", ["type"]
-declarePublicGauge waku_lightpush_v3_messages,
+declarePublicCounter waku_lightpush_v3_messages,
   "number of lightpush messages received", ["type"]
 
 # Error types (metric label values)

Diff for: waku/waku_lightpush_legacy/protocol_metrics.nim

@@ -2,9 +2,9 @@
 
 import metrics
 
-declarePublicGauge waku_lightpush_errors,
+declarePublicCounter waku_lightpush_errors,
   "number of lightpush protocol errors", ["type"]
-declarePublicGauge waku_lightpush_messages,
+declarePublicCounter waku_lightpush_messages,
   "number of lightpush messages received", ["type"]
 
 # Error types (metric label values)

Diff for: waku/waku_store/protocol_metrics.nim

@@ -2,8 +2,8 @@
 
 import metrics
 
-declarePublicGauge waku_store_errors, "number of store protocol errors", ["type"]
-declarePublicGauge waku_store_queries, "number of store queries received"
+declarePublicCounter waku_store_errors, "number of store protocol errors", ["type"]
+declarePublicCounter waku_store_queries, "number of store queries received"
 
 ## "query-db-time" phase considers the time when node performs the query to the database.
 ## "send-store-resp-time" phase is the time when node writes the store response to the store-client.

Diff for: waku/waku_store_legacy/protocol_metrics.nim

@@ -2,9 +2,9 @@
 
 import metrics
 
-declarePublicGauge waku_legacy_store_errors,
+declarePublicCounter waku_legacy_store_errors,
   "number of legacy store protocol errors", ["type"]
-declarePublicGauge waku_legacy_store_queries, "number of legacy store queries received"
+declarePublicCounter waku_legacy_store_queries, "number of legacy store queries received"
 
 ## "query-db-time" phase considers the time when node performs the query to the database.
 ## "send-store-resp-time" phase is the time when node writes the store response to the store-client.