Skip to content

Commit fa8e260

Browse files
author
aoleynikov-wallarm
authored
Merge pull request #27 from wallarm/fix-denylist
Fix a couple of bugs with denylist
2 parents 895f7ff + ea1b582 commit fa8e260

3 files changed

Lines changed: 15 additions & 6 deletions

File tree

version/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ package version
22

33
var (
44
// ProviderVersion is set during the release process to the release version of the binary
5-
ProviderVersion = "1.0.0-rc.1"
5+
ProviderVersion = "1.0.0-rc.2"
66
)

wallarm/resource_denylist.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,9 @@ func resourceWallarmDenylistRead(d *schema.ResourceData, m interface{}) error {
257257
}
258258

259259
func resourceWallarmDenylistUpdate(d *schema.ResourceData, m interface{}) error {
260+
if err := resourceWallarmDenylistDelete(d, m); err != nil {
261+
return err
262+
}
260263
return resourceWallarmDenylistCreate(d, m)
261264
}
262265

@@ -274,6 +277,10 @@ func resourceWallarmDenylistDelete(d *schema.ResourceData, m interface{}) error
274277
derivedIDs = append(derivedIDs, id["ip_id"].(int))
275278
}
276279

280+
if len(derivedIDs) == 0 {
281+
derivedIDs = append(derivedIDs, 0)
282+
}
283+
277284
if err := client.DenylistDelete(clientID, derivedIDs); err != nil {
278285
return err
279286
}

wallarm/utils.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,14 @@ func expandPointsToTwoDimensionalArray(ps []interface{}) (wallarm.TwoDimensional
201201
case "path", "array", "grpc", "json_array", "xml_comment",
202202
"xml_dtd_entity", "xml_pi", "xml_tag_array":
203203
// Align to the []string{} schema, float is used since marshalling considers numbers as float64
204-
number, err := strconv.ParseFloat(pointSlice[1].(string), 64)
205-
if err != nil {
206-
return nil, err
204+
if len(pointSlice) > 1 {
205+
number, err := strconv.ParseFloat(pointSlice[1].(string), 64)
206+
if err != nil {
207+
return nil, err
208+
}
209+
pointSlice[1] = number
210+
points[i] = pointSlice
207211
}
208-
pointSlice[1] = number
209-
points[i] = pointSlice
210212
default:
211213
points[i] = pointSlice
212214
}

0 commit comments

Comments
 (0)