concord-server: fix updateWaitConditions when wait condition without processes (#994)

Author: brig

server/impl/src/main/java/com/walmartlabs/concord/server/process/ProcessResource.java

@@ -1028,6 +1028,9 @@ public Response updateMetadata(@PathParam("id") UUID instanceId, Map<String, Obj
     public Response setWaitCondition(@PathParam("id") UUID instanceId, Map<String, Object> waitCondition) {
         ProcessKey processKey = assertProcessKey(instanceId);
         AbstractWaitCondition condition = objectMapper.convertValue(waitCondition, AbstractWaitCondition.class);
+        if (condition == null) {
+            throw new ConcordApplicationException("Wait condition is required", Status.BAD_REQUEST);
+        }
         processWaitManager.addWait(processKey, condition);
         return Response.ok().build();
     }

server/impl/src/main/java/com/walmartlabs/concord/server/process/waits/ProcessWaitWatchdog.java

@@ -158,7 +158,10 @@ void processWaits(List<WaitingProcess> processes) {
 
             try {
                 boolean updated = processWaitManager.txResult(tx -> {
-                    boolean isWaiting = !resultWaits.isEmpty() && resumeEvents.isEmpty();
+                    // TODO: better way
+                    // Right now, we have only one result action, and it moves the process to enqueued status. 
+                    // If the process moves to enqueued, it means it's no longer waiting for anything, so isWaiting should be false
+                    boolean isWaiting = !resultWaits.isEmpty() && resumeEvents.isEmpty() && resultActions.isEmpty();
                     boolean up = processWaitManager.setWait(tx, p.processKey(), resultWaits, isWaiting, p.version());
                     if (up) {
                         resultActions.forEach(a -> a.execute(tx));

server/impl/src/main/java/com/walmartlabs/concord/server/process/waits/WaitConditionUpdater.java

@@ -48,9 +48,9 @@ private static void updateWaitConditions(DSLContext tx, ProcessKey processKey, P
             SET wait_conditions =
                     (SELECT jsonb_agg(
                         CASE
-                            WHEN obj->>'type' = 'PROCESS_COMPLETION' and obj->>'completeCondition' = 'ALL'
+                            WHEN obj->>'type' = 'PROCESS_COMPLETION' and obj->>'completeCondition' = 'ALL' and obj->>'processes' is not null
                                 THEN jsonb_set(obj, '{processes}', (obj->'processes') - ?)
-                            WHEN obj->>'type' = 'PROCESS_COMPLETION' and obj->>'completeCondition' = 'ONE_OF' and obj->'processes' ?? ?
+                            WHEN obj->>'type' = 'PROCESS_COMPLETION' and obj->>'completeCondition' = 'ONE_OF' and obj->>'processes' is not null and obj->'processes' ?? ?
                                 THEN jsonb_set(obj, '{processes}', '[]')
                             ELSE obj
                         END