Skip to content

Commit 775f3cb

Browse files
committed
concord-server: bind external trigger processors explicitly
1 parent 26ef1d4 commit 775f3cb

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

server/impl/src/main/java/com/walmartlabs/concord/server/events/EventModule.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222

2323
import com.google.inject.Binder;
2424
import com.google.inject.Module;
25+
import com.walmartlabs.concord.server.events.externalevent.ExternalEventTriggerProcessor;
26+
import com.walmartlabs.concord.server.events.externalevent.ExternalEventTriggerV1Processor;
27+
import com.walmartlabs.concord.server.events.externalevent.ExternalEventTriggerV2Processor;
2528
import com.walmartlabs.concord.server.events.github.GithubTriggerProcessor;
2629
import com.walmartlabs.concord.server.sdk.events.ProcessEventListener;
2730

@@ -33,6 +36,11 @@ public class EventModule implements Module {
3336

3437
@Override
3538
public void configure(Binder binder) {
39+
newSetBinder(binder, ExternalEventTriggerProcessor.class).addBinding().to(ExternalEventTriggerV1Processor.class);
40+
newSetBinder(binder, ExternalEventTriggerProcessor.class).addBinding().to(ExternalEventTriggerV2Processor.class);
41+
42+
binder.bind(TriggerProcessExecutor.class).in(SINGLETON);
43+
3644
newSetBinder(binder, ProcessEventListener.class);
3745

3846
binder.bind(GithubTriggerProcessor.class).in(SINGLETON);

server/impl/src/main/java/com/walmartlabs/concord/server/events/TriggerProcessExecutor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,11 @@
3939
import org.slf4j.Logger;
4040
import org.slf4j.LoggerFactory;
4141

42-
import javax.inject.Named;
4342
import javax.ws.rs.core.Response;
4443
import java.util.*;
4544
import java.util.concurrent.*;
4645
import java.util.stream.Collectors;
4746

48-
@Named
4947
public class TriggerProcessExecutor {
5048

5149
public interface ProcessConfigurationEnricher {

server/impl/src/main/java/com/walmartlabs/concord/server/events/externalevent/ExternalEventTriggerV1Processor.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@
2323
import com.walmartlabs.concord.server.org.triggers.TriggersDao;
2424

2525
import javax.inject.Inject;
26-
import javax.inject.Named;
27-
import javax.inject.Singleton;
2826

29-
@Named
30-
@Singleton
3127
@Deprecated
3228
public class ExternalEventTriggerV1Processor extends ExternalEventTriggerProcessor {
3329

server/impl/src/main/java/com/walmartlabs/concord/server/events/externalevent/ExternalEventTriggerV2Processor.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,7 @@
2323
import com.walmartlabs.concord.server.org.triggers.TriggersDao;
2424

2525
import javax.inject.Inject;
26-
import javax.inject.Named;
27-
import javax.inject.Singleton;
2826

29-
@Named
30-
@Singleton
3127
public class ExternalEventTriggerV2Processor extends ExternalEventTriggerProcessor {
3228

3329
@Inject

0 commit comments

Comments
 (0)