concord-server: make Permission#isPermitted non-static

Author: ibodrov

server/impl/src/main/java/com/walmartlabs/concord/server/org/OrganizationManager.java

@@ -295,7 +295,7 @@ private static void assertAdmin() {
     }
 
     private static void assertPermission(Permission p) {
-        if (Permission.isPermitted(p)) {
+        if (p.isPermitted()) {
             return;
         }
 

server/impl/src/main/java/com/walmartlabs/concord/server/process/ProcessResourceV2.java

@@ -253,7 +253,7 @@ private ProcessFilter createProcessFilter(UUID orgId,
         } else {
             // we got a query that is not limited to any specific org
             // let's check if we can return all processes from all orgs or if we should limit it to the user's orgs
-            boolean canSeeAllOrgs = Roles.isAdmin() || Permission.isPermitted(Permission.GET_PROCESS_QUEUE_ALL_ORGS);
+            boolean canSeeAllOrgs = Roles.isAdmin() || Permission.GET_PROCESS_QUEUE_ALL_ORGS.isPermitted();
             if (!canSeeAllOrgs) {
                 // non-admin users can only see their org's processes or processes w/o projects
                 orgIds = getCurrentUserOrgIds();

server/impl/src/main/java/com/walmartlabs/concord/server/security/Permission.java

@@ -58,7 +58,7 @@ public String getKey() {
         return key;
     }
 
-    public static boolean isPermitted(Permission p) {
-        return SecurityUtils.isPermitted(p.getKey());
+    public boolean isPermitted() {
+        return SecurityUtils.isPermitted(this.getKey());
     }
 }

server/impl/src/main/java/com/walmartlabs/concord/server/security/apikey/ApiKeyResource.java

@@ -112,7 +112,7 @@ public CreateApiKeyResponse create(@PathParam("name") @ConcordKey String name) {
     public CreateApiKeyResponse create(@Valid CreateApiKeyRequest req) {
         String key = req.getKey();
 
-        if (!Permission.isPermitted(Permission.API_KEY_SPECIFY_VALUE)) {
+        if (key != null && !Permission.API_KEY_SPECIFY_VALUE.isPermitted()) {
             throw new UnauthorizedException("Not allowed to specify the API key value.");
         }