oidc: simplify redirect code in /auth

Author: ibodrov

server/plugins/oidc/src/main/java/com/walmartlabs/concord/server/plugins/oidc/OidcAuthFilter.java

@@ -31,7 +31,6 @@
 import javax.servlet.*;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-import java.io.IOException;
 
 public class OidcAuthFilter implements Filter {
 
@@ -41,14 +40,20 @@ public class OidcAuthFilter implements Filter {
     private final OidcClient<?> client;
 
     @Inject
-    public OidcAuthFilter(@Named("oidc") Config config, OidcClient<?> client) {
+    public OidcAuthFilter(PluginConfiguration pluginConfig,
+                          @Named("oidc") Config config,
+                          OidcClient<?> client) {
         this.config = config;
         this.client = client;
+
+        if (pluginConfig.isEnabled() && !client.isInitialized()) {
+            client.init();
+        }
     }
 
     @Override
     @SuppressWarnings("unchecked")
-    public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
+    public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) {
         HttpServletRequest req = (HttpServletRequest) request;
         HttpServletResponse resp = (HttpServletResponse) response;
 
@@ -57,7 +62,8 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
         String redirectUrl = req.getParameter("from");
         context.getSessionStore().set(context, Pac4jConstants.REQUESTED_URL, redirectUrl);
 
-        RedirectionAction action = client.getRedirectionAction(context)
+        RedirectionAction action = client.getRedirectionActionBuilder()
+                .getRedirectionAction(context)
                 .orElseThrow(() -> new IllegalStateException("Can't get a redirection action for the request"));
 
         config.getHttpActionAdapter().adapt(action, context);