runtime-v2: fix the duration format when generating an effective yaml (#383)

Author: brig

runtime/v2/model/src/main/java/com/walmartlabs/concord/runtime/v2/ProjectSerializerV2.java

@@ -30,6 +30,7 @@
 
 import java.io.IOException;
 import java.io.OutputStream;
+import java.time.Duration;
 
 public class ProjectSerializerV2 {
 
@@ -73,7 +74,8 @@ private static ObjectMapper createObjectMapper() {
                 .addSerializer(TaskCall.class, new TaskCallStepSerializer())
                 .addSerializer(Form.class, new FormDefinitionSerializer())
                 .addSerializer(Trigger.class, new TriggerSerializer())
-                .addSerializer(ProcessDefinition.class, new ProcessDefinitionSerializer());
+                .addSerializer(ProcessDefinition.class, new ProcessDefinitionSerializer())
+                .addSerializer(Duration.class, new DurationSerializer());
 
         return new ObjectMapper(new YAMLFactory()
                 .disable(YAMLGenerator.Feature.WRITE_DOC_START_MARKER))

runtime/v2/model/src/main/java/com/walmartlabs/concord/runtime/v2/serializer/DurationSerializer.java

@@ -0,0 +1,53 @@
+package com.walmartlabs.concord.runtime.v2.serializer;
+
+/*-
+ * *****
+ * Concord
+ * -----
+ * Copyright (C) 2017 - 2020 Walmart Inc.
+ * -----
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * =====
+ */
+
+import com.fasterxml.jackson.core.JsonGenerator;
+import com.fasterxml.jackson.databind.SerializerProvider;
+import com.fasterxml.jackson.databind.ser.std.StdSerializer;
+import com.walmartlabs.concord.runtime.v2.model.ProcessDefinition;
+
+import java.io.IOException;
+import java.time.Duration;
+import java.util.Collections;
+import java.util.stream.Collectors;
+
+import static com.walmartlabs.concord.runtime.v2.serializer.SerializerUtils.writeNotEmptyObjectField;
+
+public class DurationSerializer extends StdSerializer<Duration> {
+
+    private static final long serialVersionUID = 1L;
+
+    public DurationSerializer() {
+        this(null);
+    }
+
+    public DurationSerializer(Class<Duration> t) {
+        super(t);
+    }
+
+    @Override
+    public void serialize(Duration value, JsonGenerator gen, SerializerProvider provider) throws IOException {
+        if (value != null) {
+            gen.writeString(value.toString());
+        }
+    }
+}

runtime/v2/model/src/test/java/com/walmartlabs/concord/project/runtime/v2/ProjectSerializerV2Test.java

@@ -36,11 +36,22 @@
 import java.util.*;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 public class ProjectSerializerV2Test extends AbstractParserTest {
 
     private final ProjectSerializerV2 serializer = new ProjectSerializerV2();
 
+    @Test
+    public void testConfiguration() throws Exception {
+        ProcessDefinitionConfiguration cfg = ProcessDefinitionConfiguration.builder()
+                .processTimeout(Duration.parse("PT1H"))
+                .build();
+
+        String result = toYaml(cfg);
+        assertTrue(result.contains("processTimeout: \"PT1H\""));
+    }
+
     @Test
     public void testCheckpoint() throws Exception {
         String result = toYaml(new Checkpoint(location(), "checkpoint-1", simpleOptions()));