concord-server: use validated name when updating secrets, fix formatting

Author: ibodrov

server/impl/src/main/java/com/walmartlabs/concord/server/org/secret/SecretManager.java

@@ -368,26 +368,24 @@ public void update(UUID orgId, String secretName, SecretUpdateParams params) {
             newEncryptedData = null;
             hashAlgorithm = null;
         }
-        if(newProjectIds == null || newProjectIds.isEmpty()){
+        if (newProjectIds == null || newProjectIds.isEmpty()) {
             policyManager.checkEntity(e.getOrgId(), null, EntityType.SECRET, EntityAction.UPDATE, newOwner,
                     PolicyUtils.secretToMap(e.getOrgId(), e.getName(), e.getType(), e.getVisibility(), e.getStoreType()));
         } else {
-            newProjectIds.stream().forEach(newProjectId -> {
-                policyManager.checkEntity(e.getOrgId(), newProjectId, EntityType.SECRET, EntityAction.UPDATE, newOwner,
-                        PolicyUtils.secretToMap(e.getOrgId(), e.getName(), e.getType(), e.getVisibility(), e.getStoreType()));
-            });
+            newProjectIds.forEach(newProjectId ->
+                    policyManager.checkEntity(e.getOrgId(), newProjectId, EntityType.SECRET, EntityAction.UPDATE, newOwner,
+                            PolicyUtils.secretToMap(e.getOrgId(), e.getName(), e.getType(), e.getVisibility(), e.getStoreType())));
         }
 
         String newName = validateName(params.newName(), newOrgId, e);
-
         SecretType finalNewType = newType;
         secretDao.tx(tx -> {
             if (newOrgId != null) {
                 // update repository mapping to null when org is changing
                 repositoryDao.clearSecretMappingBySecretId(tx, e.getId());
             }
 
-            secretDao.update(tx, e.getId(), params.newName(), newOwner != null ? newOwner.getId() : null,
+            secretDao.update(tx, e.getId(), newName, newOwner != null ? newOwner.getId() : null,
                     finalNewType, newEncryptedData, params.newVisibility(), newOrgId, hashAlgorithm);
             secretDao.updateSecretProjects(tx, e.getId(), params.removeProjectLink() ? Collections.emptySet() : newProjectIds);
         });