concord-server-it: run most tests in parallel

ibodrov · ibodrov · commit fb0de20c64ad · 2025-03-22T12:28:47.000-04:00
diff --git a/client2/src/test/java/com/walmartlabs/concord/client2/SecretClientTest.java b/client2/src/test/java/com/walmartlabs/concord/client2/SecretClientTest.java
@@ -32,6 +32,7 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 @WireMockTest
+@Disabled("Doesn't work in parallel mode")
 public class SecretClientTest {
 
     @Test
diff --git a/it/runtime-v1/src/test/java/com/walmartlabs/concord/it/runtime/v1/ConcordConfiguration.java b/it/runtime-v1/src/test/java/com/walmartlabs/concord/it/runtime/v1/ConcordConfiguration.java
@@ -36,7 +36,14 @@ public static ConcordRule configure() {
                 .streamServerLogs(true)
                 .streamAgentLogs(true)
                 .useLocalMavenRepository(true)
-                .extraConfigurationSupplier(() -> "concord-agent { prefork { enabled = true } }");
+                .extraConfigurationSupplier(() -> """
+                        concord-agent {
+                            workersCount = 8
+                            prefork {
+                                enabled = true
+                            }
+                        }
+                        """);
 
         boolean localMode = Boolean.parseBoolean(System.getProperty("it.local.mode"));
         if (localMode) {
diff --git a/it/runtime-v2/src/test/java/com/walmartlabs/concord/it/runtime/v2/ConcordConfiguration.java b/it/runtime-v2/src/test/java/com/walmartlabs/concord/it/runtime/v2/ConcordConfiguration.java
@@ -60,6 +60,7 @@ public static ConcordRule configure() {
                 .useLocalMavenRepository(true)
                 .extraConfigurationSupplier(() -> """
                     concord-agent {
+                        workersCount = 8
                         dependencyResolveTimeout = "30 seconds"
                         logMaxDelay = "250 milliseconds"
                         pollInterval = "250 milliseconds"
diff --git a/it/runtime-v2/src/test/java/com/walmartlabs/concord/it/runtime/v2/ConcordTaskIT.java b/it/runtime-v2/src/test/java/com/walmartlabs/concord/it/runtime/v2/ConcordTaskIT.java
@@ -27,11 +27,14 @@
 import com.walmartlabs.concord.sdk.Constants;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import static com.walmartlabs.concord.it.common.ITUtils.randomString;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class ConcordTaskIT extends AbstractTest {
 
     @RegisterExtension
diff --git a/it/runtime-v2/src/test/java/com/walmartlabs/concord/it/runtime/v2/GitHubTriggersV2IT.java b/it/runtime-v2/src/test/java/com/walmartlabs/concord/it/runtime/v2/GitHubTriggersV2IT.java
@@ -29,6 +29,7 @@
 import com.walmartlabs.concord.it.common.ITUtils;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 import org.testcontainers.shaded.com.fasterxml.jackson.databind.ObjectMapper;
 
 import java.nio.file.Path;
@@ -40,7 +41,9 @@
 
 import static com.walmartlabs.concord.it.common.ITUtils.randomString;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class GitHubTriggersV2IT extends AbstractTest {
 
     @RegisterExtension
diff --git a/it/server/src/test/java/com/walmartlabs/concord/it/server/ConcordTaskIT.java b/it/server/src/test/java/com/walmartlabs/concord/it/server/ConcordTaskIT.java
@@ -545,7 +545,7 @@ public void testForkAsyncGrabOutVars() throws Exception {
         // ---
         byte[] ab = getLog(pe.getInstanceId());
         if (grep(".*\\{x=1, y=2, z=3\\}.*", ab).isEmpty()
-                || grep(".*\\{a=4, b=5, c=6\\}.*", ab).isEmpty()) {
+            || grep(".*\\{a=4, b=5, c=6\\}.*", ab).isEmpty()) {
 
             for (UUID id : pe.getChildrenIds()) {
                 ProcessEntry pp = new ProcessV2Api(getApiClient()).getProcess(id, Collections.singleton("childrenIds"));
diff --git a/it/server/src/test/java/com/walmartlabs/concord/it/server/GeneralTriggerIT.java b/it/server/src/test/java/com/walmartlabs/concord/it/server/GeneralTriggerIT.java
@@ -24,13 +24,17 @@
 import com.walmartlabs.concord.common.IOUtils;
 import org.eclipse.jgit.api.Git;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.io.File;
 import java.nio.file.Path;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class GeneralTriggerIT extends AbstractGeneralTriggerIT {
 
     @Test
diff --git a/it/server/src/test/java/com/walmartlabs/concord/it/server/GeneralTriggerV2IT.java b/it/server/src/test/java/com/walmartlabs/concord/it/server/GeneralTriggerV2IT.java
@@ -24,13 +24,17 @@
 import com.walmartlabs.concord.common.IOUtils;
 import org.eclipse.jgit.api.Git;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.io.File;
 import java.nio.file.Path;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class GeneralTriggerV2IT extends AbstractGeneralTriggerIT {
 
     private String orgName;
diff --git a/it/server/src/test/java/com/walmartlabs/concord/it/server/GitHubTriggersV2IT.java b/it/server/src/test/java/com/walmartlabs/concord/it/server/GitHubTriggersV2IT.java
@@ -24,6 +24,8 @@
 import com.walmartlabs.concord.client2.ProcessListFilter;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
+import org.junit.jupiter.api.parallel.ExecutionMode;
 
 import javax.naming.NameAlreadyBoundException;
 import javax.naming.directory.*;
@@ -34,7 +36,9 @@
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class GitHubTriggersV2IT extends AbstractGitHubTriggersIT {
 
     @AfterEach
diff --git a/it/server/src/test/java/com/walmartlabs/concord/it/server/OutVariablesProjectIT.java b/it/server/src/test/java/com/walmartlabs/concord/it/server/OutVariablesProjectIT.java
@@ -22,6 +22,7 @@
 
 import com.walmartlabs.concord.client2.*;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.util.Collections;
 import java.util.HashMap;
@@ -31,7 +32,9 @@
 import static com.walmartlabs.concord.it.common.ServerClient.assertLog;
 import static com.walmartlabs.concord.it.common.ServerClient.waitForCompletion;
 import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class OutVariablesProjectIT extends AbstractServerIT {
 
     @Test
diff --git a/it/server/src/test/resources/agent.conf b/it/server/src/test/resources/agent.conf
@@ -4,8 +4,11 @@ concord-agent {
     logMaxDelay = "250 milliseconds"
     pollInterval = "250 milliseconds"
 
+    workersCount = 32
+
     prefork {
         enabled = true
+        maxCount = 1
     }
 
     capabilities = {
diff --git a/it/server/src/test/resources/server.conf b/it/server/src/test/resources/server.conf
@@ -1,5 +1,7 @@
 concord-server {
     db {
+        maxPoolSize = 20
+
         changeLogParameters {
             defaultAdminToken = "cTFxMXExcTE="
             defaultAgentToken = "cTJxMnEycTI="
diff --git a/plugins/tasks/http/src/test/java/com/walmartlabs/concord/plugins/http/HttpTaskTest.java b/plugins/tasks/http/src/test/java/com/walmartlabs/concord/plugins/http/HttpTaskTest.java
@@ -25,6 +25,7 @@
 import com.walmartlabs.concord.sdk.Context;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.io.File;
 import java.nio.file.Path;
@@ -34,9 +35,11 @@
 
 import static com.github.tomakehurst.wiremock.client.WireMock.*;
 import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class HttpTaskTest extends AbstractHttpTaskTest {
 
     private final Context mockContext = mock(Context.class);
diff --git a/plugins/tasks/mock/src/test/java/com/walmartlabs/concord/plugins/mock/MockTest.java b/plugins/tasks/mock/src/test/java/com/walmartlabs/concord/plugins/mock/MockTest.java
@@ -23,11 +23,14 @@
 import com.walmartlabs.concord.runtime.v2.runner.TestRuntimeV2;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.util.regex.Pattern;
 
 import static com.walmartlabs.concord.runtime.v2.runner.TestRuntimeV2.assertLog;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class MockTest {
 
     @RegisterExtension
diff --git a/plugins/tasks/mock/src/test/java/com/walmartlabs/concord/plugins/mock/VerifyTest.java b/plugins/tasks/mock/src/test/java/com/walmartlabs/concord/plugins/mock/VerifyTest.java
@@ -24,7 +24,11 @@
 import com.walmartlabs.concord.runtime.v2.runner.TestRuntimeV2;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
+
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class VerifyTest {
 
     @RegisterExtension
diff --git a/plugins/tasks/smtp/src/test/java/com/walmartlabs/concord/plugins/smtp/SmtpTaskTest.java b/plugins/tasks/smtp/src/test/java/com/walmartlabs/concord/plugins/smtp/SmtpTaskTest.java
@@ -27,6 +27,7 @@
 import com.walmartlabs.concord.sdk.MockContext;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import javax.mail.internet.MimeMessage;
 import javax.mail.internet.MimeMultipart;
@@ -37,8 +38,10 @@
 import java.util.Map;
 
 import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
 @SuppressWarnings("deprecation")
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class SmtpTaskTest {
 
     @RegisterExtension
diff --git a/plugins/tasks/smtp/src/test/java/com/walmartlabs/concord/plugins/smtp/SmtpTaskV2Test.java b/plugins/tasks/smtp/src/test/java/com/walmartlabs/concord/plugins/smtp/SmtpTaskV2Test.java
@@ -28,6 +28,7 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import javax.mail.internet.MimeMessage;
 import java.nio.file.Paths;
@@ -36,9 +37,11 @@
 import java.util.Map;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class SmtpTaskV2Test {
 
     @RegisterExtension
diff --git a/pom.xml b/pom.xml
@@ -256,6 +256,13 @@
                             <include>**/Test*.java</include>
                         </includes>
                         <argLine>${failsafe.args}</argLine>
+                        <systemProperties>
+                            <junit.jupiter.execution.parallel.enabled>true</junit.jupiter.execution.parallel.enabled>
+                            <junit.jupiter.execution.parallel.mode.default>concurrent</junit.jupiter.execution.parallel.mode.default>
+                            <junit.jupiter.execution.parallel.mode.classes.default>same_thread</junit.jupiter.execution.parallel.mode.classes.default>
+                            <junit.jupiter.execution.parallel.config.strategy>fixed</junit.jupiter.execution.parallel.config.strategy>
+                            <junit.jupiter.execution.parallel.config.fixed.parallelism>4</junit.jupiter.execution.parallel.config.fixed.parallelism>
+                        </systemProperties>
                     </configuration>
                     <executions>
                         <execution>
@@ -277,6 +284,15 @@
                             <version>${junit.version}</version>
                         </dependency>
                     </dependencies>
+                    <configuration>
+                        <systemProperties>
+                            <junit.jupiter.execution.parallel.enabled>true</junit.jupiter.execution.parallel.enabled>
+                            <junit.jupiter.execution.parallel.mode.default>concurrent</junit.jupiter.execution.parallel.mode.default>
+                            <junit.jupiter.execution.parallel.mode.classes.default>same_thread</junit.jupiter.execution.parallel.mode.classes.default>
+                            <junit.jupiter.execution.parallel.config.strategy>fixed</junit.jupiter.execution.parallel.config.strategy>
+                            <junit.jupiter.execution.parallel.config.fixed.parallelism>4</junit.jupiter.execution.parallel.config.fixed.parallelism>
+                        </systemProperties>
+                    </configuration>
                 </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
diff --git a/runtime/v2/runner-test/src/test/java/com/walmartlabs/concord/runtime/v2/runner/LogExceptionsTest.java b/runtime/v2/runner-test/src/test/java/com/walmartlabs/concord/runtime/v2/runner/LogExceptionsTest.java
@@ -23,11 +23,14 @@
 import com.walmartlabs.concord.runtime.v2.sdk.ProcessConfiguration;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import static com.walmartlabs.concord.runtime.v2.runner.TestRuntimeV2.*;
 import static java.util.regex.Pattern.quote;
 import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class LogExceptionsTest {
 
     @RegisterExtension
diff --git a/runtime/v2/runner-test/src/test/java/com/walmartlabs/concord/runtime/v2/runner/LogSegmentsTest.java b/runtime/v2/runner-test/src/test/java/com/walmartlabs/concord/runtime/v2/runner/LogSegmentsTest.java
@@ -28,6 +28,7 @@
 import com.walmartlabs.concord.runtime.v2.sdk.ProcessConfiguration;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
@@ -40,7 +41,9 @@
 import static com.walmartlabs.concord.runtime.v2.runner.TestRuntimeV2.assertMultiLineLog;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class LogSegmentsTest {
 
     @RegisterExtension
diff --git a/runtime/v2/runner-test/src/test/java/com/walmartlabs/concord/runtime/v2/runner/MainTest.java b/runtime/v2/runner-test/src/test/java/com/walmartlabs/concord/runtime/v2/runner/MainTest.java
@@ -28,6 +28,7 @@
 import com.walmartlabs.concord.runtime.v2.sdk.ProcessConfiguration;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.parallel.Execution;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
@@ -40,8 +41,10 @@
 import static com.walmartlabs.concord.runtime.v2.runner.TestRuntimeV2.*;
 import static java.util.regex.Pattern.quote;
 import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;
 import static org.mockito.Mockito.*;
 
+@Execution(SAME_THREAD) // TODO address parallelism issues
 public class MainTest  {
 
     @RegisterExtension
