From a773f93ca47ba7b8e93417a0d69bf78476d60956 Mon Sep 17 00:00:00 2001 From: Ivan Bodrov Date: Thu, 19 Sep 2024 09:22:31 -0400 Subject: [PATCH] concord-server: bind EventEnrichers explicitly --- .../com/walmartlabs/concord/server/events/EventModule.java | 1 + .../server/events/github/GithubTriggerProcessor.java | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/impl/src/main/java/com/walmartlabs/concord/server/events/EventModule.java b/server/impl/src/main/java/com/walmartlabs/concord/server/events/EventModule.java index cbf5acf7ef..623627fa2e 100644 --- a/server/impl/src/main/java/com/walmartlabs/concord/server/events/EventModule.java +++ b/server/impl/src/main/java/com/walmartlabs/concord/server/events/EventModule.java @@ -34,5 +34,6 @@ public class EventModule implements Module { public void configure(Binder binder) { newSetBinder(binder, ProcessEventListener.class); binder.bind(GithubTriggerProcessor.class).in(SINGLETON); + newSetBinder(binder, GithubTriggerProcessor.EventEnricher.class).addBinding().to(GithubTriggerProcessor.RepositoryInfoEnricher.class); } } diff --git a/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/GithubTriggerProcessor.java b/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/GithubTriggerProcessor.java index 8db6d130ad..8dc96c79fe 100644 --- a/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/GithubTriggerProcessor.java +++ b/server/impl/src/main/java/com/walmartlabs/concord/server/events/github/GithubTriggerProcessor.java @@ -54,12 +54,12 @@ public class GithubTriggerProcessor { private static final Logger log = LoggerFactory.getLogger(GithubTriggerProcessor.class); private final Dao dao; - private final List eventEnrichers; + private final Set eventEnrichers; private final boolean isDisableReposOnDeletedRef; @Inject public GithubTriggerProcessor(Dao dao, - List eventEnrichers, + Set eventEnrichers, GithubConfiguration githubCfg) { this.dao = dao; this.eventEnrichers = eventEnrichers; @@ -203,8 +203,7 @@ public interface EventEnricher { * Adds {@link Trigger#REPOSITORY_INFO} property to the event, but only if * the trigger's conditions contained the clause with the same key. */ - @Named - private static class RepositoryInfoEnricher implements EventEnricher { + public static class RepositoryInfoEnricher implements EventEnricher { private final Dao dao;