Merge pull request #476 from walmartlabs/hls/20260602-fix-448-tracing-validation

fix: tracing validation fields always null (#448)

Author: hlship

src/com/walmartlabs/lacinia.clj

@@ -57,9 +57,9 @@
     (resolve/resolve-as {:errors validation-errors})
 
     :else
-    (executor/execute-query (assoc context constants/parsed-query-key prepared
-                                           ::tracing/validation {:start-offset start-offset
-                                                                 :duration (tracing/duration start-nanos)}))))
+    (executor/execute-query (assoc context constants/parsed-query-key (assoc prepared
+                                                                             ::tracing/validation {:start-offset start-offset
+                                                                                                   :duration (tracing/duration start-nanos)})))))
 
 (defn execute-parsed-query
   "Prepares a query, by applying query variables to it, resulting in a prepared

src/com/walmartlabs/lacinia/executor.clj

@@ -417,7 +417,7 @@
                                                                  *resolver-tracing
                                                                  (tracing/inject-tracing timing-start
                                                                                          (::tracing/parsing parsed-query)
-                                                                                         (::tracing/validation context)
+                                                                                         (::tracing/validation parsed-query)
                                                                                          @*resolver-tracing)
                                                                  errors (assoc :errors (distinct errors))
                                                                  warnings (assoc-in [:extensions :warnings] (distinct warnings))))))))

test/com/walmartlabs/lacinia/tracing_test.clj

@@ -100,3 +100,13 @@
                (let [durations (->> (get-in result [:extensions :tracing :execution :resolvers])
                                     (mapv :duration))]
                  (is (= 6 (count durations)))))))
+
+(deftest parsing-and-validation-timings-are-non-nil
+  ;; Regression test for https://github.com/walmartlabs/lacinia/issues/448
+  (let [result (q "{ root(delay: 5) { simple }}" enable-timing)
+        {:keys [parsing validation]} (get-in result [:extensions :tracing])]
+    (reporting result
+               (is (some? (:startOffset parsing)) "parsing startOffset should not be nil")
+               (is (pos? (:duration parsing)) "parsing duration should be positive")
+               (is (some? (:startOffset validation)) "validation startOffset should not be nil")
+               (is (pos? (:duration validation)) "validation duration should be positive"))))