Skip to content
This repository was archived by the owner on Mar 20, 2021. It is now read-only.
This repository was archived by the owner on Mar 20, 2021. It is now read-only.

Empty item templates produces holes in collection #408

@kpdecker

Description

@kpdecker

This can lead to future rendering failures when an inserted item's sibling can not be found.

  it('should work with empty elements', function() {
    var view = new Thorax.View({
      template: Handlebars.compile("{{#collection}}\n{{#if render}}\n{{letter}}\n{{/if}}\n{{/collection}}"),
      collection: new Thorax.Collection([
        {letter: 'a', render: false},
        {letter: 'b', render: true},
        {letter: 'c', render: false},
        {letter: 'd', render: true},
        {letter: 'e', render: true}
      ])
    });
    view.render();
    expect(view.$el.text()).to.equal('bde');
    expect(view.$('[data-model-cid]').length).to.equal(5);
  });

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions