Skip to content

Commit 20fee34

Browse files
committed
correct some smells
1 parent cbf1350 commit 20fee34

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

app/build.gradle.kts

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,27 @@ repositories {
1919
}
2020

2121
dependencies {
22+
val javalinVersion = "6.7.0"
23+
val jteVersion = "3.2.1"
24+
var lombokVersion = "1.18.38"
25+
2226
testImplementation(platform("org.junit:junit-bom:5.11.4"))
2327
testImplementation("org.junit.jupiter:junit-jupiter")
28+
testImplementation("com.squareup.okhttp3:mockwebserver3:5.1.0")
29+
testImplementation("org.mockito:mockito-core:5.18.0")
2430

25-
implementation("io.javalin:javalin-bundle:6.7.0")
31+
implementation("io.javalin:javalin-bundle:$javalinVersion")
32+
implementation("io.javalin:javalin-rendering:$javalinVersion")
33+
implementation("gg.jte:jte:$jteVersion")
34+
implementation("gg.jte:jte-watcher:$jteVersion")
2635
implementation("org.slf4j:slf4j-simple:2.0.17")
27-
implementation("io.javalin:javalin-rendering:6.7.0")
28-
implementation("gg.jte:jte:3.2.1")
29-
implementation("gg.jte:jte-watcher:3.2.1")
30-
31-
compileOnly("org.projectlombok:lombok:1.18.38")
32-
annotationProcessor("org.projectlombok:lombok:1.18.38")
33-
3436
implementation("com.h2database:h2:2.3.232")
3537
implementation("com.zaxxer:HikariCP:6.3.0")
3638
implementation("org.postgresql:postgresql:42.7.7")
37-
3839
implementation("com.konghq:unirest-java-core:4.4.7")
39-
testImplementation("com.squareup.okhttp3:mockwebserver3:5.1.0")
40-
testImplementation("org.mockito:mockito-core:5.18.0")
40+
41+
compileOnly("org.projectlombok:lombok:$lombokVersion")
42+
annotationProcessor("org.projectlombok:lombok:$lombokVersion")
4143
}
4244

4345
tasks.test {

app/src/main/java/hexlet/code/App.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ private static String getDatabaseUrl() {
5555
private static TemplateEngine createTemplateEngine() {
5656
ClassLoader classLoader = App.class.getClassLoader();
5757
ResourceCodeResolver codeResolver = new ResourceCodeResolver("templates", classLoader);
58-
TemplateEngine templateEngine = TemplateEngine.create(codeResolver, ContentType.Html);
59-
return templateEngine;
58+
return TemplateEngine.create(codeResolver, ContentType.Html);
6059
}
6160

6261
protected static Javalin getApp() throws SQLException, IOException {
@@ -71,7 +70,7 @@ protected static Javalin getApp() throws SQLException, IOException {
7170
var sql = readResourceFile("schema.sql");
7271
statement.execute(sql);
7372
} catch (NullPointerException e) {
74-
System.out.println("No SQL schema found");
73+
LOG.info("No SQL schema found");
7574
}
7675

7776
BaseRepository.dataSource = dataSource;

0 commit comments

Comments
 (0)