Skip to content

Commit 48664fe

Browse files
committed
Don't delete requester if deletion of a stopped instance fails
1 parent d9a86ad commit 48664fe

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/controller/dual-pods/inference-server.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,8 @@ func (item infSvrItem) process(urCtx context.Context, ctl *controller, nodeDat *
389389
_, delErr := lClient.DeleteInstance(ctx, serverDat.InstanceID)
390390
if delErr != nil && !IsLauncherNotFoundError(delErr) {
391391
logger.V(3).Info("Failed to delete stopped instance from launcher", "instanceID", serverDat.InstanceID, "err", delErr)
392+
return ctl.ensureReqStatus(ctx, requestingPod, serverDat,
393+
fmt.Sprintf("failed to delete stopped instance %q from launcher: %s", serverDat.InstanceID, delErr.Error()))
392394
}
393395
// Mark as sleeping so that ensureUnbound (called during requester deletion)
394396
// does not attempt to POST /sleep on the dead instance.

0 commit comments

Comments
 (0)