Skip to content

Commit a688573

Browse files
committed
Review updates to fix env var. and docs
Signed-off-by: aavarghese <avarghese@us.ibm.com>
1 parent 9375b8a commit a688573

File tree

4 files changed

+3
-55
lines changed

4 files changed

+3
-55
lines changed

.github/workflows/publish-release.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ jobs:
7474
TAG="${{ steps.version.outputs.tag }}"
7575
reg="${{ github.repository }}"
7676
77-
KO_DOCKER_REPO=ghcr.io/${reg@L} \
7877
make build-controller \
7978
CONTAINER_IMG_REG=ghcr.io/${reg@L} \
8079
CONTROLLER_IMG_TAG=$TAG
@@ -89,7 +88,6 @@ jobs:
8988
TAG="${{ steps.version.outputs.tag }}"
9089
reg="${{ github.repository }}"
9190
92-
KO_DOCKER_REPO=ghcr.io/${reg@L} \
9391
make build-populator \
9492
CONTAINER_IMG_REG=ghcr.io/${reg@L} \
9593
POPULATOR_IMG_TAG=$TAG

docs/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
- [Launcher](launcher.md)
44
- [Fast Model Actuation with Process Flexibility and Dual Pods](dual-pods.md)
55

6-
# Dev/test of dual-pods controller
6+
# Dev/test
77

88
- [Local dev/test in a `kind` cluster](local-test.md)
99
- [Manual end-to-end testing using a real cluster](e2e-recipe.md)
@@ -20,7 +20,6 @@
2020
- [End-to-end testing in CI using a `kind` cluster](../.github/workflows/pr-test-in-kind.yml)
2121
- [Release – Build Images & Publish Helm Charts to GHCR](../.github/workflows/publish-release.yaml)
2222

23-
# Helm Charts
23+
# Release
2424

25-
- [Helm chart installation](helm-install.md)
2625
- [Release process](release-process.md)

docs/helm-install.md

Lines changed: 0 additions & 48 deletions
This file was deleted.

docs/release-process.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ git push origin v0.3.1 # or your tag name
5959

6060
### 3. Automated Workflow Execution
6161

62-
Once you publish the release, the `publish-release` workflow *will kick-off* automatically as follows:
62+
Once you publish the release, the `publish-release` workflow runs automatically and performs the following steps:
6363

6464
1. **Builds 4 container images**:
6565
- `ghcr.io/llm-d-incubation/llm-d-fast-model-actuation/dual-pods-controller:v0.3.1`
@@ -86,5 +86,4 @@ Use the GitHub Actions UI to manually trigger the workflow with a specific tag
8686

8787
## Related Documentation
8888

89-
- [Helm Chart Installation](helm-install.md) - How to install the published charts
9089
- [Workflow Source](../.github/workflows/publish-release.yaml) - The actual workflow implementation

0 commit comments

Comments
 (0)