Skip to content

Commit b280d90

Browse files
Merge pull request llm-d-incubation#156 from waltforme/1119
Switch from 'server-running pod' to 'server-providing pod' for all .go files
2 parents c0b5582 + 32cc48d commit b280d90

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

pkg/controller/dual-pods/controller.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,25 +47,25 @@ import (
4747
// The controller works in the context of one Kubernetes API namespace.
4848

4949
// A Pod is a server-requesting Pod if it has the server patch annotation.
50-
// A Pod is a bound server-running Pod if it has an annotation
50+
// A Pod is a bound server-providing Pod if it has an annotation
5151
// with the name "dual-pods.llm-d.ai/requester"; the annotations's value should
5252
// be `requestingPod.UID + " " + requestingPod.Name`.
53-
// A Pod is an unbound server-running Pod if it (1) is not bound and
53+
// A Pod is an unbound server-providing Pod if it (1) is not bound and
5454
// (2) has an annotation
5555
// with name "dual-pods.llm-d.ai/nominal", whose value should be the base64 encoding
56-
// of the SHA-256 hash of bytes that are characteristic of the nominal server-running Pod
56+
// of the SHA-256 hash of bytes that are characteristic of the nominal server-providing Pod
5757
// (including node, GPUs; excluding its name, this annotation, and the identity of the server-requesting Pod).
5858
// This API object metadata is the hard state about binding.
5959

60-
// A bound server-running Pod normally has an awake inference server,
60+
// A bound server-providing Pod normally has an awake inference server,
6161
// with possible exceptions during startup, shutdown, binding, and unbinding.
62-
// An unbound server-running Pod has an inference server that is sleeping.
62+
// An unbound server-providing Pod has an inference server that is sleeping.
6363

64-
// The controller includes its finalizer when creating a bound server-running Pod,
65-
// and removes it when unbinding or recognizing the exogenous deletion of a server-running Pod.
64+
// The controller includes its finalizer when creating a bound server-providing Pod,
65+
// and removes it when unbinding or recognizing the exogenous deletion of a server-providing Pod.
6666

6767
// At this interim stage of development, the controller does not request
68-
// deletion of any server-running Pod. Nor does the controller ever try to bind
68+
// deletion of any server-providing Pod. Nor does the controller ever try to bind
6969
// one that is unbound; they are only created in the bound state.
7070

7171
// There are two types of item in the controller's work queue.
@@ -235,7 +235,7 @@ type serverData struct {
235235
NominalProvidingPod *corev1.Pod
236236
NominalProvidingPodHash string
237237

238-
// ServerPort is meaningful if NominalRunningPod is not nil
238+
// ServerPort is meaningful if NominalProvidingPod is not nil
239239
ServerPort int16
240240

241241
// UUIDs of the server's GPUs

0 commit comments

Comments
 (0)