Commit 1d560a1
Han Wang
fix(api_cc): keep graph edges extended for multi-rank native-spin
The graph-branch edge construction still hardcoded fold_to_local=true,
a leftover from when the multi-rank fail-fast guaranteed single-rank on
this route. After the fail-fast was replaced by the with-comm dispatch,
run_model_graph_with_comm consumed the FOLDED edge list as if it were
extended: every src collapsed into [0, nloc), the owned-ghost
environment edges vanished (E=4, src in {0,1} on each rank of the NiO
fixture), and the 2-rank energy/force/force_mag deviated from the
1-rank result by up to 1e-1 while remaining decomposition-independent.
Mirror the non-spin twin (DeepPotPTExpt.cc graph branch): fold only when
the with-comm route is not taken. Covered by
test_pair_deepspin_mpi_matches_single_rank (2-rank vs 1-rank at 1e-10).1 parent 0123bcb commit 1d560a1
1 file changed
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
816 | 816 | | |
817 | 817 | | |
818 | 818 | | |
819 | | - | |
820 | | - | |
821 | | - | |
822 | | - | |
823 | | - | |
824 | | - | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
825 | 827 | | |
826 | 828 | | |
827 | 829 | | |
828 | | - | |
| 830 | + | |
829 | 831 | | |
830 | 832 | | |
831 | 833 | | |
| |||
0 commit comments