Skip to content

Commit 285e3c6

Browse files
author
Han Wang
committed
fix(test): drop a duplicated assignment and a stale ownership docstring
- The harness extraction emitted `data_file_empty_rank` twice in a row: the preserved comment block already carried the assignment and the rewrite template added it again. A runtime no-op, but a patch artifact in the commit whose point was a clean single-owner harness. - TestNativeSpinWithBridging still described `get_standard_model` as the owner of the bridging composition, which is the opposite of the contract this branch establishes: that builder now rejects `bridging_method`, and `get_native_spin_model` routes DPA4/SeZM to `get_sezm_model` and re-classes the composition it returns.
1 parent 0408b38 commit 285e3c6

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

source/lmp/tests/test_lammps_dpa4_spin_graph_pt2.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@
9292
# phantom path and none trips the genuinely-empty fail-fast. The shifted
9393
# coordinates (``coord_empty_rank``) are defined below, after ``coord``.
9494
data_file_empty_rank = Path(__file__).parent / "data_dpa4_spin_graph_pt2_empty_rank.lmp"
95-
data_file_empty_rank = Path(__file__).parent / "data_dpa4_spin_graph_pt2_empty_rank.lmp"
9695
# The MPI runner is graph-spin-specific (no aparam / no NULL-type
9796
# extras, unlike run_mpi_pair_deepmd_spin_dpa3_pt2.py's virtual-atom-scheme
9897
# runner): the native-spin DPA4 fixture takes no fparam/aparam.

source/tests/pt_expt/model/test_zbl_bridging.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -275,10 +275,12 @@ def _spin_system():
275275
class TestNativeSpinWithBridging:
276276
"""Native spin + analytical bridging compose (review 3649276109).
277277
278-
``get_standard_model`` OWNS assembling the atomic model, bridging
279-
composition included, and the native-spin wrapper re-classes whatever it
280-
returns -- so the two features combine with no special case: the learned
281-
child consumes ``spin``, the analytical child accepts and ignores it.
278+
``get_sezm_model`` OWNS the bridging composition (``get_standard_model``
279+
rejects ``bridging_method``: a composition is not expressible on a
280+
non-composite model type). ``get_native_spin_model`` routes DPA4/SeZM
281+
configs there and then RE-CLASSES the returned composition -- so the two
282+
features combine with no special case: the learned child consumes
283+
``spin``, the analytical child accepts and ignores it.
282284
"""
283285

284286
def test_construction_composes_and_keeps_spin(self) -> None:

0 commit comments

Comments
 (0)