Skip to content

Commit a28392f

Browse files
author
lihua
committed
fix: simplify release workflow by removing unnecessary conditions and improving version handling
1 parent c73880b commit a28392f

1 file changed

Lines changed: 9 additions & 35 deletions

File tree

.github/workflows/release.yml

Lines changed: 9 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ name: Release
22

33
on:
44
push:
5-
branches:
6-
- main
75
tags:
86
- 'v*'
97
workflow_dispatch:
@@ -52,14 +50,7 @@ jobs:
5250
id: app-version
5351
shell: bash
5452
run: |
55-
base_version="$(node -p "require('./package.json').version")"
56-
57-
if [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
58-
app_version="${GITHUB_REF_NAME#v}"
59-
else
60-
app_version="${base_version}-nightly.${GITHUB_RUN_NUMBER}"
61-
fi
62-
53+
app_version="${GITHUB_REF_NAME#v}"
6354
echo "app_version=${app_version}" >> "$GITHUB_OUTPUT"
6455
6556
- name: Rewrite package version for packaged app
@@ -110,33 +101,16 @@ jobs:
110101
id: meta
111102
shell: bash
112103
run: |
113-
base_version="$(node -p "require('./package.json').version")"
114-
115-
if [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
116-
tag="${GITHUB_REF_NAME}"
117-
name="${GITHUB_REF_NAME}"
118-
prerelease=false
119-
make_latest=true
120-
body="$(git tag -l --format='%(contents)' "${GITHUB_REF_NAME}")"
121-
if [[ -z "${body//[[:space:]]/}" ]]; then
122-
body="Stable release ${GITHUB_REF_NAME}."
123-
fi
124-
app_version="${GITHUB_REF_NAME#v}"
125-
else
126-
short_sha="${GITHUB_SHA::7}"
127-
timestamp="$(date -u +'%Y-%m-%d %H:%M UTC')"
128-
tag="nightly-${short_sha}"
129-
name="Nightly ${timestamp} (${short_sha})"
130-
prerelease=true
131-
make_latest=false
132-
body="Automated prerelease from main at commit ${GITHUB_SHA}."
133-
app_version="${base_version}-nightly.${GITHUB_RUN_NUMBER}"
104+
tag="${GITHUB_REF_NAME}"
105+
name="${GITHUB_REF_NAME}"
106+
app_version="${GITHUB_REF_NAME#v}"
107+
body="$(git tag -l --format='%(contents)' "${GITHUB_REF_NAME}")"
108+
if [[ -z "${body//[[:space:]]/}" ]]; then
109+
body="Stable release ${GITHUB_REF_NAME}."
134110
fi
135111
136112
echo "tag=${tag}" >> "$GITHUB_OUTPUT"
137113
echo "name=${name}" >> "$GITHUB_OUTPUT"
138-
echo "prerelease=${prerelease}" >> "$GITHUB_OUTPUT"
139-
echo "make_latest=${make_latest}" >> "$GITHUB_OUTPUT"
140114
echo "app_version=${app_version}" >> "$GITHUB_OUTPUT"
141115
printf '%s\n' "${body}" > release-notes.txt
142116
@@ -152,5 +126,5 @@ jobs:
152126
artifactErrorsFailBuild: true
153127
allowUpdates: true
154128
replacesArtifacts: true
155-
prerelease: ${{ steps.meta.outputs.prerelease }}
156-
makeLatest: ${{ steps.meta.outputs.make_latest }}
129+
prerelease: false
130+
makeLatest: true

0 commit comments

Comments
 (0)