Skip to content

Commit 033c70f

Browse files
committed
Temporarily remove --all-features from clippy invocations.
1 parent 0dbd3d5 commit 033c70f

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,8 @@ jobs:
510510
if [ "${{ matrix.os }}" = "windows" ]; then
511511
cargo clippy --locked --workspace ${{ matrix.clippy_excludes }} --all-targets --tests -- -D warnings
512512
else
513-
cargo clippy --locked --workspace ${{ matrix.clippy_excludes }} --all-targets --all-features --tests -- -D warnings
513+
# TODO(vorporeal): Re-enable the `all-features` flag once we've fixed things.
514+
cargo clippy --locked --workspace ${{ matrix.clippy_excludes }} --all-targets --tests -- -D warnings
514515
# Run clippy on warp_completer with default, rather than all features enabled, because there is
515516
# feature-gated logic for the WIP completions-on-js implementation.
516517
cargo clippy --locked -p warp_completer --all-targets --tests -- -D warnings

script/presubmit

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ echo "Cargo fmt succeeded..."
2020

2121
echo "Running clippy..."
2222
# Exclude warp_completer because we run clippy on it with default features (rather than all features) below.
23-
cargo clippy --workspace --exclude warp_completer --all-targets --all-features --tests -- -D warnings
23+
#
24+
# TODO(vorporeal): Re-enable the `all-features` flag once we've fixed things.
25+
cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings
2426
# Run clippy on warp_completer with default, rather than all features enabled, because there is
2527
# feature-gated logic for the WIP completions-on-js implementation.
2628
cargo clippy -p warp_completer --all-targets --tests -- -D warnings

0 commit comments

Comments
 (0)