Skip to content

Commit b3ace7d

Browse files
committed
Avoid parallel precheck execution
1 parent 34d311d commit b3ace7d

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

crates/remote_server/src/manager.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -482,16 +482,16 @@ impl RemoteServerManager {
482482
ctx.background_executor()
483483
.spawn(async move {
484484
// Run platform detection, binary check, and old-binary
485-
// check concurrently. The old-binary check lets the
486-
// controller distinguish fresh install (no prior
487-
// versioned binary) from update (prior versioned
488-
// binary present), so it can skip the install prompt
489-
// in the update case.
490-
let (platform_result, check_result, old_binary_result) = futures::join!(
491-
transport.detect_platform(),
492-
transport.check_binary(),
493-
transport.check_has_old_binary(),
494-
);
485+
// check sequentially so that each step reuses the
486+
// same SSH ControlMaster connection instead of
487+
// opening parallel channels. The old-binary check
488+
// lets the controller distinguish fresh install (no
489+
// prior versioned binary) from update (prior
490+
// versioned binary present), so it can skip the
491+
// install prompt in the update case.
492+
let platform_result = transport.detect_platform().await;
493+
let check_result = transport.check_binary().await;
494+
let old_binary_result = transport.check_has_old_binary().await;
495495
let platform = match platform_result {
496496
Ok(p) => Some(p),
497497
Err(e) => {

0 commit comments

Comments
 (0)